Repository navigation
Conversation
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #76788 [ run ] triggered by Bot. Commit: |
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #77064 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #77064 [ run ] completed with state
|
Collaborator
|
@peihu-nv how much of this is specific to K3 vs generic for other mamba / hybrid models? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
K3 checkpoint-planning foundation only. Full support requires the relevant Rubin-advance merge-back and porting the integrated implementation from internal MR !10793. Retention additionally requires #20001.
K3 cache reuse needs the complete attention prefix and the recurrent/convolution state at the same checkpoint endpoint. This draft adds a transfer planner using the existing connector layout and block hash chain. It describes every payload and scale region, separates shared attention objects from endpoint-private state, and validates a completion manifest before restore.
This is the preparatory checkpoint contract, not working K3 Mooncake serving support. Native snapshot pinning, transfer retirement, request adoption, and executor integration remain to be implemented and validated. The producer must supply an independently pinned exact checkpoint and a representation identity covering weights and layout. Sliding-window layouts are rejected; existing serving restrictions remain intact.
The intended integration uses the generic connector work in #19171, the lending lifecycle in #19722, and private-checkpoint retention in #20001. This draft does not copy their transport, allocator, or retention implementations and can be reviewed independently.
Test Coverage
tests/unittest/_torch/executor/test_mooncake_k3_checkpoint.py: payload/scales coverage, endpoint and representation isolation, address-independent manifests, partial/failed completion, invalid slots, and unsupported layouts.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.