Repository navigation
[https://nvbugs/6731978][test] unwaive B200 Qwen3-235B NVFP4 TRTLLM MoE test - #19916
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe B200 ChangesTest waiver
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable issue is identified with enabling this test. Merge readiness remains subject to normal validation. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies NVBug 6731978, the test-related change, and the specific B200 Qwen3-235B NVFP4 TRTLLM MoE waiver removal. |
| Description check | |
The description explains the change and rationale, lists pre-commit and manual validation results, identifies the CI target, and marks the checklist as reviewed. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Removed the "ci: full pre-merge approved" label because @jiahanc could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #76473 [ run ] triggered by Bot. Commit: |
|
PR_Github #76474 [ run ] triggered by Bot. Commit: |
|
PR_Github #76473 [ run ] completed with state |
|
PR_Github #76474 [ run ] completed with state |
…oE test Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
eb2fa46 to
3540ac1
Compare
Barry-Delaney
left a comment
Barry-Delaney
left a comment
There was a problem hiding this comment.
Reviewed 3540ac1: this only removes the B200 Qwen3-235B NVFP4 TRTLLM MoE waiver. The exact test ID remains in the multi-node test list with its existing timeout and isolation settings. No runtime-code change or blocking code issue.
mikeiovine
left a comment
mikeiovine
left a comment
There was a problem hiding this comment.
Stamp on behalf of runtime devs
|
/bot run --disable-fail-fast |
|
PR_Github #77356 [ run ] triggered by Bot. Commit: |
|
PR_Github #77356 [ run ] completed with state |
Description
Remove the B200 waiver for
TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm](NVBug 6731978).Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
The change removes the B200 waiver for
TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm](NVBug 6731978). The test remains in the B200 multi-node CI list withTIMEOUT (90) ISOLATION, so the test can run when that list is selected. No source-code changes are reported.QA Engineer Review
Only a test-list file changed. The removed waiver changes test selection; no test function or test ID changed. The test remains in
test-db/l0_gb200_multi_nodes.ymland in two manual-QA lists. The author reports that pre-commit passed and manual validation on 8x B200 passed on release 1.3.0rc29, with MMLU and GSM8K scores above their stated thresholds. The reported post-merge runs had mixed outcomes: one was aborted and one succeeded; the associated pipeline was markedPartly Tested. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Removes the waiver for the B200 Qwen3-235B NVFP4 TRTLLM MoE test. Verify the test in current-main CI; the reported manual run used release 1.3.0rc29.