Skip to content

[https://nvbugs/6843482][fix] Unwaive TTP NVLINK_ONE_SIDED CUTLASS NVFP4 test_configurable_moe_multi_gpu - #19876

Closed
zhangcl wants to merge 1 commit into
NVIDIA:mainfrom
zhangcl:user/chulianz/unwaive-6843482
Closed

zhangcl wants to merge 1 commit into
NVIDIA:mainfrom
zhangcl:user/chulianz/unwaive-6843482

Conversation

@zhangcl

@zhangcl zhangcl commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Unwaive test_configurable_moe_multi_gpu[parallel=TTP-comm=NVLINK_ONE_SIDED-...-CUTLASS-NVFP4-...]; the hang is fixed by #19780.

Dev Engineer Review

The change removes one waiver for the test_configurable_moe_multi_gpu TTP/NVLINK_ONE_SIDED/NVFP4 CUTLASS case. No source or runtime behavior changed. The PR description attributes the hang fix to PR #19780; this change does not include that fix.

QA Engineer Review

The waiver removal allows the targeted case to run instead of being skipped. CI lists include other test_configurable_moe_multi_gpu cases, but the supplied search did not find the exact targeted selector. Test execution results are not provided. Coverage verdict: needs follow-up.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Removes the waiver for the targeted integration-test case. The matching case was not confirmed in the CI or manual-QA lists.

…FP4 test_configurable_moe_multi_gpu

Fixed by NVIDIA#19780 (NCCL env vars set before ncclGetUniqueId).

Signed-off-by: Chulian Zhang <851104+zhangcl@users.noreply.github.com>
@zhangcl
zhangcl requested a review from xxi-nv October 6, 2026 05:13
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: aa4a3bb5-cecd-48a5-823d-d18a0a792ace
📥 Commits

Reviewing files that changed from the base of the PR and between 37d332f and 665ee67.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The skip-list entry for test_configurable_moe_multi_gpu with TTP, NVLINK_ONE_SIDED, and NVFP4 settings was removed from waives.txt.

Changes

MoE test skip-list update

Layer / File(s) Summary
Remove configurable MoE test skip entry
tests/integration/test_lists/waives.txt
The skip list no longer includes the entry for the specified test settings and nvbugs/6843482.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: bowenfu

Merge Risk: ⚪ Minimal · up to 665ee

The test can now run on eligible hardware. No concrete failure was established that would block merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the unwaive change and the affected test configuration. It follows the repository’s ticket-and-type format.
Description check ✅ Passed The description states which test is unwaived and explains that the hang was fixed by PR #19780. It does not use the template headings or explicitly list test coverage, but it provides the main contex…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@zhangcl

zhangcl commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-3"

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76321 [ run ] triggered by Bot. Commit: 665ee67 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76321 [ run ] completed with state SUCCESS. Commit: 665ee67
/LLM/main/L0_MergeRequest_PR pipeline #62926 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@zhangcl

zhangcl commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-3"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76331 [ run ] triggered by Bot. Commit: 665ee67 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76331 [ run ] completed with state SUCCESS. Commit: 665ee67
/LLM/main/L0_MergeRequest_PR pipeline #62935 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@zhangcl

zhangcl commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-1,DGX_B200-4_GPUs-PyTorch-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76408 [ run ] triggered by Bot. Commit: 665ee67 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76408 [ run ] completed with state SUCCESS. Commit: 665ee67
/LLM/main/L0_MergeRequest_PR pipeline #63002 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@zhangcl

zhangcl commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #20786, which already removed this waive entry from waives.txt on main. CI runs on this branch (PR_Github #76331, #76408) passed with the test unwaived.

@zhangcl zhangcl closed this Nov 4, 2026
@zhangcl
zhangcl deleted the user/chulianz/unwaive-6843482 branch November 4, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants