Repository navigation
Conversation
…FP4 test_configurable_moe_multi_gpu Fixed by NVIDIA#19780 (NCCL env vars set before ncclGetUniqueId). Signed-off-by: Chulian Zhang <851104+zhangcl@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe skip-list entry for ChangesMoE test skip-list update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The test can now run on eligible hardware. No concrete failure was established that would block merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-3" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #76321 [ run ] triggered by Bot. Commit: |
|
PR_Github #76321 [ run ] completed with state
|
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-3" |
|
PR_Github #76331 [ run ] triggered by Bot. Commit: |
|
PR_Github #76331 [ run ] completed with state |
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-1,DGX_B200-4_GPUs-PyTorch-2" |
|
PR_Github #76408 [ run ] triggered by Bot. Commit: |
|
PR_Github #76408 [ run ] completed with state |
|
Superseded by #20786, which already removed this waive entry from |
Unwaive
test_configurable_moe_multi_gpu[parallel=TTP-comm=NVLINK_ONE_SIDED-...-CUTLASS-NVFP4-...]; the hang is fixed by #19780.Dev Engineer Review
The change removes one waiver for the
test_configurable_moe_multi_gpuTTP/NVLINK_ONE_SIDED/NVFP4 CUTLASS case. No source or runtime behavior changed. The PR description attributes the hang fix to PR#19780; this change does not include that fix.QA Engineer Review
The waiver removal allows the targeted case to run instead of being skipped. CI lists include other
test_configurable_moe_multi_gpucases, but the supplied search did not find the exact targeted selector. Test execution results are not provided. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Removes the waiver for the targeted integration-test case. The matching case was not confirmed in the CI or manual-QA lists.