Skip to content

[None][ci] waive pre-existing test failures on main - #19462

Merged
chzblych merged 1 commit into
NVIDIA:mainfrom
brnguyen2:prbs/waives
Sep 21, 2026
Merged

chzblych merged 1 commit into
NVIDIA:mainfrom
brnguyen2:prbs/waives

Conversation

@brnguyen2

@brnguyen2 brnguyen2 commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

Waives for pre-existing test failures on main, each with a filed tracking bug. These failures block unrelated PRs; landing the waives here keeps them out of those PRs' diffs.

Test Tracking bug Blocked PR(s)
unittest/_torch/multimodal/test_mm_encoder_standalone.py::test_epd_disagg_mm_hash_kv_cache_reuse[prompts0] https://nvbugs/6812085 #19454
unittest/usage/test_llmapi_config_telemetry_docs.py::test_build_capture_manifest_matches_committed_golden https://nvbugs/6811958 #19457, #19455, #19458

Maintained by pr-babysitter: entries are pruned automatically as main picks their tests up, and the PR closes itself when nothing is left to carry. The branch is regenerated on each change — do not push to it.

Dev Engineer Review

The change adds two waiver entries to tests/integration/test_lists/waives.txt. It does not change source code or public APIs. The waivers address pre-existing failures for NVBUG 6812085 and NVBUG 6811958. Risk is limited to temporarily suppressing those tests until the related issues are resolved.

QA Engineer Review

tests/integration/test_lists/waives.txt adds waivers for:

  • The multimodal encoder standalone KV-cache reuse test.
  • The LLM API telemetry documentation capture-manifest golden test.

No test implementation changed. The change affects test selection only. Coverage verdict: needs follow-up until the waivers are removed and both tests pass without suppression.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds two integration-test waiver entries for NVBUG 6812085 and NVBUG 6811958. Verify that the entries match the intended tests and are automatically removed when main includes the fixes.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 518d6b97-0f55-449e-b0ed-f3563a18a6d7

📥 Commits

Reviewing files that changed from the base of the PR and between ab4cc32 and 4d16b6a.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

The integration waiver list now skips the multimodal encoder KV-cache reuse test and the LLM API telemetry documentation golden test. Each entry references its associated NVBUG.

Changes

Integration test waivers

Layer / File(s) Summary
Add integration test waivers
tests/integration/test_lists/waives.txt
Adds skip-list entries for the multimodal encoder standalone EPD disaggregation KV-cache reuse test and the LLM API telemetry documentation capture-manifest golden test. The entries reference NVBUG 6812085 and NVBUG 6811958.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: chzblych

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the waiver purpose, identifies both affected tests, links each tracking bug, lists blocked pull requests, and documents the automated pruning behavior. It does not inc…
Title check ✅ Passed The title is concise and accurately identifies a CI waiver for pre-existing test failures on main. The [None] ticket marker and [ci] change type match the repository title convention.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74680 [ run ] triggered by Bot. Commit: ab4cc32 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74680 [ run ] completed with state SUCCESS. Commit: ab4cc32
/LLM/main/L0_MergeRequest_PR pipeline #61466 completed with status: 'SUCCESS'

CI Report

Link to invocation

…ne.py::test_epd_disagg_mm_hash_kv_cache_reuse[prompts0], unittest/usage/test_llmapi_config_telemetry_docs.py::test_build_capture_manifest_matches_committed_golden (pre-existing failures on main; tracking bugs in the PR description)

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
@chzblych

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Test waives"

@chzblych
chzblych enabled auto-merge (squash) September 21, 2026 00:48
@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74691 [ skip ] triggered by Bot. Commit: 4d16b6a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74691 [ skip ] completed with state SUCCESS. Commit: 4d16b6a
Skipping testing for commit 4d16b6a

Link to invocation

@chzblych
chzblych merged commit f7c29d7 into NVIDIA:main Sep 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants