Repository navigation
[None][ci] waive pre-existing test failures on main - #19462
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe integration waiver list now skips the multimodal encoder KV-cache reuse test and the LLM API telemetry documentation golden test. Each entry references its associated NVBUG. ChangesIntegration test waivers
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #74680 [ run ] triggered by Bot. Commit: |
|
PR_Github #74680 [ run ] completed with state |
…ne.py::test_epd_disagg_mm_hash_kv_cache_reuse[prompts0], unittest/usage/test_llmapi_config_telemetry_docs.py::test_build_capture_manifest_matches_committed_golden (pre-existing failures on main; tracking bugs in the PR description) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
ab4cc32 to
4d16b6a
Compare
|
/bot skip --comment "Test waives" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #74691 [ skip ] triggered by Bot. Commit: |
|
PR_Github #74691 [ skip ] completed with state |
Waives for pre-existing test failures on
main, each with a filed tracking bug. These failures block unrelated PRs; landing the waives here keeps them out of those PRs' diffs.unittest/_torch/multimodal/test_mm_encoder_standalone.py::test_epd_disagg_mm_hash_kv_cache_reuse[prompts0]unittest/usage/test_llmapi_config_telemetry_docs.py::test_build_capture_manifest_matches_committed_goldenMaintained by pr-babysitter: entries are pruned automatically as
mainpicks their tests up, and the PR closes itself when nothing is left to carry. The branch is regenerated on each change — do not push to it.Dev Engineer Review
The change adds two waiver entries to
tests/integration/test_lists/waives.txt. It does not change source code or public APIs. The waivers address pre-existing failures for NVBUG 6812085 and NVBUG 6811958. Risk is limited to temporarily suppressing those tests until the related issues are resolved.QA Engineer Review
tests/integration/test_lists/waives.txtadds waivers for:No test implementation changed. The change affects test selection only. Coverage verdict: needs follow-up until the waivers are removed and both tests pass without suppression.
Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds two integration-test waiver entries for NVBUG 6812085 and NVBUG 6811958. Verify that the entries match the intended tests and are automatically removed whenmainincludes the fixes.