Repository navigation
[https://nvbugs/6241845][fix] Guard both the FP4 and FP8 DSL atom-split branches with `next_n ==… - #14904
[https://nvbugs/6241845][fix] Guard both the FP4 and FP8 DSL atom-split branches with `next_n ==…#14904tensorrt-cicd wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR refines atom-split expansion gating in the CuTe DSL paged MQA decode path. A new ChangesCuTe DSL atom-split expansion gating
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #51827 [ run ] triggered by Bot. Commit: |
76b9a48 to
939cee8
Compare
|
PR_Github #51827 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52191 [ run ] triggered by Bot. Commit: |
|
PR_Github #52191 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #52473 [ run ] triggered by Bot. Commit: |
|
PR_Github #52473 [ run ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot --help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
… indexer The cached dsl_expand_factor/dsl_atom are picked for the full MTP window (next_n = 1 + max_draft_tokens). MTP also issues per-token draft calls with next_n == 1, whose q_decode holds only num_generations tokens. Applying the cached split there reshaped to factor x too many slots, crashing CUDA-graph warmup. Only split when next_n == factor * atom. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
939cee8 to
9be566b
Compare
|
NVBug 6241845 was closed as Bug - Fixed. The repair-bot root cause matches the merged resolution #14891, so this PR is being auto-closed. If you believe this is wrong, reopen the PR — the bot will never auto-close a human-reopened PR for this cleanup generation. |
Summary
dsl_expand_factor/dsl_atomwere picked for the full MTP window (next_n=1+max_draft_tokens=4), but the atom-split was applied unconditionally — including on MTP per-token draft calls where next_n==1, so the reshape targeted factor× too many token slots ([48,2,64,64]=393216 vs input 98304).next_n == metadata.dsl_expand_factor * metadata.dsl_atom, so the split only applies on the full-window forward and next_n==1 draft calls fall through to the kernel-native path.Test plan
Links
Summary by CodeRabbit