Skip to content

[TRTLLM-9847][fix] WAR fix hanging fused allreduce. #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg-kwasniewski1 merged 3 commits into from
Dec 22, 2025
Merged

[TRTLLM-9847][fix] WAR fix hanging fused allreduce. #10087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec2927b
By default, unmatched lin nodes are not sharded
greg-kwasniewski1 Dec 17, 2025
3c04dd9
updated documentatino
greg-kwasniewski1 Dec 17, 2025
3a96a61
Restored default behavior
greg-kwasniewski1 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorrt_llm/_torch/auto_deploy/config/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ transforms:
sharding_source: ['manual', 'factory', 'heuristic']
support_partial_config: true
sharding_dims: ['tp', 'ep', 'bmm']
shard_all_unprocessed: true
allreduce_strategy: 'NCCL'
dist_backend: auto
requires_shape_prop: true
Expand Down
8 changes: 7 additions & 1 deletion tensorrt_llm/_torch/auto_deploy/transform/library/sharding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ class ShardingTransformConfig(TransformConfig):
sharding_dims: List[ShardingDim] = Field(
default_factory=lambda: [ShardingDim.TP, ShardingDim.EP, ShardingDim.BMM]
)
shard_all_unprocessed: bool = Field(
default=False,
description="When True, apply simple shard (column split + all_gather) to "
"'leftover' linear nodes that are not part of any layer subgraph.",
)
allreduce_strategy: AllReduceStrategy = Field(
default=AllReduceStrategy.AUTO,
description="AllReduce strategy for distributed operations. "
Expand Down Expand Up @@ -2608,7 +2613,8 @@ def detect_column_row_shard(
num_attention_shards += 1

# simple shard remaining linear nodes
num_simple_shards += _process_simple_shard(unprocessed_linear_nodes, transform_container)
if config.shard_all_unprocessed:
num_simple_shards += _process_simple_shard(unprocessed_linear_nodes, transform_container)
num_column_row_shards += num_ssm_shards
num_shards = num_simple_shards + num_column_row_shards
ad_logger.info(
Expand Down