Skip to content

[Feature][AutoDeploy]: Support custom sharding config #8948

Closed

Description

@greg-kwasniewski1

🚀 The feature, motivation and pitch

Enable specifying sharding config manually, similarly to factory's base_model_tp_plan. The feature should enable specifying priority order between custom sharding config, factory, and heuristics.

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Activity

  1. added
    feature requestNew feature or request. This includes new model, dtype, functionality support
    on Nov 5, 2025
  2. coderabbitai commented on Nov 5, 2025

    @coderabbitai
    Contributor

    A summary of the changes CodeRabbit can apply:

    • Implement custom sharding support by adding a CUSTOM option to ShardingConfigSource (tensorrt_llm/_torch/auto_deploy/models/factory.py), extending ShardingConfig with custom_config, sharding_priority, _validate_custom_config, get_active_config and refactored validation (tensorrt_llm/_torch/auto_deploy/utils/sharding_utils.py), adding custom_sharding_config and sharding_priority fields to ShardingTransformConfig (tensorrt_llm/_torch/auto_deploy/transform/library/sharding.py), updating Sharding._apply to accept and set custom_sharding_config into shared_config.sharding_config and use priority-based get_active_config logic, and renaming/updating detect_sharding_from_factory_config to detect_sharding_from_config to accept both HUGGINGFACE and CUSTOM — enabling user-provided sharding with configurable precedence while remaining backward compatible.

    • Update tensorrt_llm/_torch/auto_deploy/models/factory.py to document and add a CUSTOM ShardingConfigSource enum value, and modify tensorrt_llm/_torch/auto_deploy/utils/sharding_utils.py to introduce custom_config and sharding_priority fields, refactor validate_config to choose and validate configs by priority, add _validate_factory_config and _validate_custom_config helpers, and add get_active_config to return the active sharding plan (falling back to heuristics) — enabling user-provided sharding, prioritized selection, and clearer validation and logging.

    • ✅ Create PR with these edits
    • 📋 Get copyable edits
  3. moved this from Backlog to In progress in AutoDeploy Boardon Nov 5, 2025
  4. greg-kwasniewski1 commented on Nov 13, 2025

    @greg-kwasniewski1
    CollaboratorAuthor
  5. moved this from In progress to In review in AutoDeploy Boardon Nov 14, 2025
  6. added a commit that references this issue on Nov 28, 2025
  7. added a commit that references this issue on Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoDeploy<NV> AutoDeploy Backendfeature requestNew feature or request. This includes new model, dtype, functionality support

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions