[Pebble] poco.origin(x, y) function is applied inconsistently

[EvanDSanders]

Build environment: Linux : Kubuntu Focus 24.04
Moddable SDK version: Pebble Tool v5.0.37 (active SDK: v4.9.169)
Target device: Emery / Pebble Time 2

Description
The Pebble Moddable Alloy SDK's poco.origin(x, y); function is applied inconstantly.

• Text is not affected at all
• Fill Rectangle is offset twice
• The Bitmap is applied twice, but the mask/clip is only applied once.

Steps to Reproduce
Install Pebble Tool and SDK v4.9.169 then:

git clone https://github.com/EvanDSanders/alloy-origin-test
cd alloy-origin-test
./run.sh

Expected behavior
All drawing methods should be moved by poco.origin() by the specified amount.

Images

Other information

I think it's related to this file:
commodettoPocoBlit-pebble.c
But I'm not completely sure because I couldn't get a VM to compile with changes to that file.

[phoddie]

Thanks for writing this up and providing an example project. Very helpful.

Embarrassingly, last weekend I had noticed that the origin is handled inconsistently when working on a font rendering issue. But, I forgot to go back and check all the cases. This issue report is a good reminder to do that.

[phoddie]

The main problem is that the origin was being applied at the wrong layer. The "blit" functions receive coordinates with the origin applied. I've corrected all the errors I saw. Your test image draws as expected now:

Regarding this comment in your example...

	// pop the origin off the stack
	// also the emulator crashes without this for some reason
	poco.origin();

	poco.end();

The emulator isn't crashing. The call to end() throws an exception because the origin stack is unbalanced. That should appear in the log, but it may not be entirely clear. We've recently implemented support for xsbug, our JavaScript debugger, for Pebble. We expect the Core Devices team to land that in a Pebble SDK update shortly. With xsbug, you'll stop on the exception and all will be clear. ;)

[phoddie]

Closing as this has been fixed. Please re-open with additional information if the issue remains. Thank you.