Repository navigation
Gradle 9 - #159
Merged
Merged
Gradle 9#159
Conversation
Prepare for the upcoming bump of Error Prone, which reports UnnecessaryStringBuilder, RedundantControlFlow, EffectivelyPrivate, IntLiteralCast and UnnecessaryParentheses warnings. Note that the toString() methods use " " instead of ' ' in the string concatenation, as otherwise the numeric fields would be added to the char value instead of being concatenated.
minidns-repl does not contain any Scala sources, hence there is no need for the scala plugin and scalastyle. Ammonite, and with it the Scala library, is still pulled in as dependency.
The mainClassName convention property is gone in Gradle 9. Also drop the applicationDefaultJvmArgs and the run configuration, as both are already provided by the application-conventions plugin.
Align MiniDNS' build-logic with the one of Smack, which already uses Gradle 9: - Rename the common-conventions plugin to global-conventions and the java-conventions plugin to java-common-conventions - Read the version file in settings.gradle, instead of in every project - Lazily determine the Android boot classpath, so that ANDROID_HOME is only required if the Android runtime jar is actually needed - Register javadocAll lazily and drop evaluationDependsOnChildren() - Prefer Maven Central over the local Maven repository - Add the gradle-versions-plugin and the copyJavadocDocFiles workaround - Show the test's standard streams if GRADLE_TEST_SHOW_STANDARD_STREAMS is set Also bump bnd to 7.3.0, gradle-errorprone-plugin to 4.3.0, gradle-animalsniffer-plugin to 2.0.1, Error Prone to 2.41.0, jacoco to 0.8.15, JUnit to 5.12.2 and junit-platform-launcher to 1.12.2. The latter fixes the version mismatch between the JUnit Jupiter and the JUnit platform artifacts.
Sonatype's OSSRH (oss.sonatype.org) has been shut down, and artifacts are now published via the Maven Central Portal. Use the gradle-maven-publish-plugin for publishing, as Smack does. The tests jar is still part of the publication, so that other projects can continue to consume the tests of MiniDNS. Note that the customRepoUrl option is gone, and that the credentials are now provided via the mavenCentralUsername and mavenCentralPassword properties.
Coverage Report for CI Build 39128505260Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.2%) to 60.81%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions39 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.