Repository navigation
Conversation
Flowdalic
force-pushed
the
dnssec-validation-partly-invalid-signatures
branch
from
October 18, 2026 10:38
525eccb to
aa2402c
Compare
Coverage Report for CI Build 39121651542Coverage increased (+0.2%) to 60.175%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions13 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
When parsing NSEC and NSEC3 RRs, types unknown to MiniDNS, for example the private use type 65534 that BIND places at many zone apexes, were dropped from the type list. The type bitmap was then re-created from the remaining known types, so the serialized RDATA used for signature verification no longer matched the signed data. As a result, DNSSEC validation of affected responses, like the NXDOMAIN for github.xxx, failed with "Signature is invalid". Parsed NSEC(3) RRs now keep the type bitmap as received. The new typeValues field exposes all types, including unknown ones, which toString() renders as "TYPE<value>" as per RFC 3597. Note that the cause presumed in MiniDNS#121, a zone with partly invalid signatures, was not the actual cause: all signatures of the .xxx zone are valid, MiniDNS altered the signed data while parsing it. Thanks to René Kilczan for reporting this. Fixes MiniDNS#121.
Flowdalic
force-pushed
the
dnssec-validation-partly-invalid-signatures
branch
from
October 18, 2026 11:02
aa2402c to
5f2d899
Compare
|
Finally yeah. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing NSEC and NSEC3 RRs, types unknown to MiniDNS, for example the private use type 65534 that BIND places at many zone apexes, were dropped from the type list. The type bitmap was then re-created from the remaining known types, so the serialized RDATA used for signature verification no longer matched the signed data. As a result, DNSSEC validation of affected responses, like the NXDOMAIN for github.xxx, failed with "Signature is invalid".
Parsed NSEC(3) RRs now keep the type bitmap as received. The new typeValues field exposes all types, including unknown ones, which toString() renders as "TYPE" as per RFC 3597.
Note that the cause presumed in #121, a zone with partly invalid signatures, was not the actual cause: all signatures of the .xxx zone are valid, MiniDNS altered the signed data while parsing it.
Thanks to René Kilczan for reporting this.
Fixes #121.