[WIP] Add links to what's new in F# 4 and add the docs for new API functions by eriawan · Pull Request #193 · MicrosoftDocs/visualfsharpdocs

Eriawan Kusumawardhono (eriawan) · 2016-06-29T07:54:58Z

Following the new addition of What's new in F# 4 (by Den (@dend) ), this is my addition as revision to the What's new in F# 4, and also create a new MD for new APIs as highlighted in the What's new, such as Option.filter, Option.toNullable functions.

If this is OK, please do not merge this. I will continue to update What's new in F# MD to contain the link to the new API functions as well. I might have to update the Option module (the core.option-module-[fsharp].md) too.
In this PR, I'll focus on the what's new and keep adding the MD for the new Option, String and Checked, Async.AwaitTask (non generic) function APIs, that are not yet documented.

Then if I have done the additions and updates, we can merge this.

cc Den (@dend)

…filter

Orca (orcabot) · 2016-06-29T07:55:01Z

docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Orca (orcabot) · 2016-06-29T07:55:02Z

Hi! I'm your friendly content validation bot. For this PR to be labeled as ready-to-merge, you'll need at least 2 comments from our designated community approvers containing the magic phrase LGTM (Looks good to me also works, for those of us that are really verbose).

Den (@dend) Kevin Ransom (@KevinRansom) Phillip Carter (@cartermp) Dan Fernandez (@thedanfernandez) Don Syme (@dsyme) - please validate this PR.

Orca (orcabot) · 2016-06-30T17:10:55Z

docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Phillip Carter (cartermp) · 2016-06-30T17:14:02Z

👍 Eriawan Kusumawardhono (@eriawan)! I changed the title here to have "WIP" in it, so that we can know at a glance that you'll still be updating this with more links.

Den (dend) · 2016-06-30T19:18:50Z

 #### Language, compiler, runtime, interactive

-* Normalization and expansion of `Array`, `List`, and `Seq` modules
+* Normalization and expansion of `Array`(Collections.Array-Module-%5BFSharp%5D.md), `List`(Collections.List-Module-%5BFSharp%5D.md), and `Seq`(Collections.Seq-Module-%5BFSharp%5D.md) modules


I believe you also want to wrap the actual strings (such as Array) in square brackets to make sure that those work as links.

Den (@dend)
OK, I'm changing this now. Thanks for your corrections 👍

Orca (orcabot) · 2016-07-01T02:47:54Z

docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Orca (orcabot) · 2016-07-01T03:03:54Z

docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Den (dend) · 2016-07-01T14:46:45Z

Great, thanks Eriawan Kusumawardhono (@eriawan). Because it's a new doc, you will also need to include it in the TOC.md file, so it shows up properly in the left nav.

Just create a reference to option.filter['t]-function-[fsharp].md in the appropriate place within the TOC.

Orca (orcabot) · 2016-07-02T18:07:52Z

docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Den (dend) · 2016-07-02T19:48:38Z

+title: Option.filter<'T> Function (F#)
+description: Option.filter<'T> Function (F#)
+keywords: visual f#, f#, functional programming
+author: dend


Because this is an entirely new article, please make sure that the author: field represents you 😄 So just use your github ID for it Eriawan Kusumawardhono (@eriawan)

ok, I'll change this now.

hang on, this is WIP :)

Orca (orcabot) · 2016-07-04T09:59:21Z

docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Orca (orcabot) · 2016-07-04T12:10:35Z

docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Den (dend) · 2016-07-05T01:09:59Z

+
+## Syntax
+
+```


Add a syntax identifier here: fsharp (right after the triple back tick).

Thanks Den (@dend)

I'm now also adding fsharp syntax identifier for all functions in option, not just option.filter because most of them doesn't have fsharp syntax identififer.

Currently I'm still adding doc for new APIs including Option.toNullable. I'll add fsharp syntax identifier as well to the rest of the new APIs doc.

Orca (orcabot) · 2016-07-05T20:43:30Z

docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.foldback['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.fold['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.map['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.iter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.forall['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.
docs/conceptual/option.bind['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.toarray['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.isnone['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.count['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tolist['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.exists['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.

Den (dend) · 2016-07-06T19:10:06Z

This LGTM. Let me know if you are ready and I will merge it. Eriawan Kusumawardhono (@eriawan)

Orca (orcabot) · 2016-07-08T11:09:47Z

docs/conceptual/option.tolist['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.exists['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.foldback['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.toarray['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tonullable['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.bind['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.
docs/conceptual/option.forall['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.isnone['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.fold['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.map['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.iter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.count['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.

Orca (orcabot) · 2016-07-08T11:29:12Z

docs/conceptual/option.map['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.bind['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.forall['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.toarray['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tonullable['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.exists['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.foldback['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.fold['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.count['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.isnone['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tolist['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.
docs/conceptual/option.iter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.

Eriawan Kusumawardhono (eriawan) · 2016-07-08T11:33:02Z

hi Den (@dend)

I have finished editing all of the option functions and add option.filter, option.tonullable URL to the what's new in F# and add links to core.option module.

Please review and merge them, thanks! 👍

Orca (orcabot) · 2016-07-08T11:37:27Z

docs/conceptual/option.iter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.isnone['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.forall['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.fold['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.bind['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.exists['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.toarray['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tolist['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.map['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tonullable['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.
docs/conceptual/option.foldback['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.count['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.

Orca (orcabot) · 2016-07-08T11:44:50Z

docs/conceptual/option.count['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.exists['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.toarray['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tonullable['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.foldback['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.tolist['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.bind['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.forall['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.fold['t,'state]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.iter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.map['t,'u]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.isnone['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/core.option-module-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/option.filter['t]-function-[fsharp].md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains URLs. Make sure that non-Microsoft URLs are using the aka.ms shortener.
docs/conceptual/whats-new-in-visual-fsharp.md - Article contains an image. Make sure that it has ALT text and is referenced from the repo. Check for attribution.

Phillip Carter (cartermp) · 2016-07-08T18:10:21Z

👍

Eriawan Kusumawardhono added 2 commits June 29, 2016 10:24

Refine What's new in F#: part 1, Add URL link for Array, List and Seq

9bd2a54

Refine What's new in F#: part 2, Add new documentation MD for Option.…

f3ef145

…filter

Orca (orcabot) added the do-not-merge label Jun 29, 2016

Eriawan Kusumawardhono (eriawan) mentioned this pull request Jun 30, 2016

New functions added to List, Array, Seq modules in F# 4.0 are missing Docs #184

Open

Phillip Carter (cartermp) changed the title ~~Add links to what's new in F# 4 and add the docs for new API functions~~ [WIP] Add links to what's new in F# 4 and add the docs for new API functions Jun 30, 2016

dend reviewed Jun 30, 2016
View reviewed changes

fix URL in what's new and continue editing option.filter

9382163

test link

4230a4e

add option filter to TOC

54ab308

dend reviewed Jul 2, 2016
View reviewed changes

Eriawan Kusumawardhono (eriawan) added 3 commits July 4, 2016 15:33

continue edit option.filter

b7bdff4

Merge branch 'master'

63328f7

add option.filter URL to core.option module

2b25bf8

fix and make URL to be HTTP friendly

609f7b0

dend reviewed Jul 5, 2016
View reviewed changes

add fsharp to the md code for all function in option

4c36921

Add the new option.tonullable to TOC and core.option

2e3749f

add link to option.tonullable to whats new in visual f#

0ecabb2

fix option.tonullable signature

f3686ab

remove whitespaces

6621008

Den (dend) added review-exempt and removed do-not-merge labels Jul 8, 2016

Den (dend) merged commit e89f88b into MicrosoftDocs:master Jul 8, 2016

Eriawan Kusumawardhono (eriawan) deleted the Add_links_WhatsNewFS4 branch July 8, 2016 23:06


		## Syntax

		```

Conversation

Eriawan Kusumawardhono (eriawan) commented Jun 29, 2016

Uh oh!

Orca (orcabot) commented Jun 29, 2016

Uh oh!

Orca (orcabot) commented Jun 29, 2016

Uh oh!

Orca (orcabot) commented Jun 30, 2016

Uh oh!

Phillip Carter (cartermp) commented Jun 30, 2016

Uh oh!

Den (dend) Jun 30, 2016

Choose a reason for hiding this comment

Uh oh!

Eriawan Kusumawardhono (eriawan) Jul 1, 2016

Choose a reason for hiding this comment

Uh oh!

Orca (orcabot) commented Jul 1, 2016

Uh oh!

Orca (orcabot) commented Jul 1, 2016

Uh oh!

Den (dend) commented Jul 1, 2016

Uh oh!

Orca (orcabot) commented Jul 2, 2016

Uh oh!

Den (dend) Jul 2, 2016

Choose a reason for hiding this comment

Uh oh!

Eriawan Kusumawardhono (eriawan) Jul 3, 2016

Choose a reason for hiding this comment

Uh oh!

Orca (orcabot) commented Jul 4, 2016

Uh oh!

Orca (orcabot) commented Jul 4, 2016

Uh oh!

Den (dend) Jul 5, 2016

Choose a reason for hiding this comment

Uh oh!

Eriawan Kusumawardhono (eriawan) Jul 5, 2016

Choose a reason for hiding this comment

Uh oh!

Orca (orcabot) commented Jul 5, 2016

Uh oh!

Den (dend) commented Jul 6, 2016

Uh oh!

Orca (orcabot) commented Jul 8, 2016

Uh oh!

Orca (orcabot) commented Jul 8, 2016

Uh oh!

Eriawan Kusumawardhono (eriawan) commented Jul 8, 2016

Uh oh!

Orca (orcabot) commented Jul 8, 2016

Uh oh!

Orca (orcabot) commented Jul 8, 2016

Uh oh!

Phillip Carter (cartermp) commented Jul 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants