Skip to content

Update documentation on accessing System.String characters - #5940

Merged
v-dirichards merged 4 commits into
MicrosoftDocs:mainfrom
AaronRobinsonMSFT:patch-3
Jul 7, 2026
Merged

Update documentation on accessing System.String characters#5940
v-dirichards merged 4 commits into
MicrosoftDocs:mainfrom
AaronRobinsonMSFT:patch-3

Conversation

@AaronRobinsonMSFT

Copy link
Copy Markdown
Contributor

Added important note about treating interior pointers as const and linked to unsafe code best practices.

Added important note about treating interior pointers as const and linked to unsafe code best practices.
@prmerger-automator

Copy link
Copy Markdown
Contributor

@AaronRobinsonMSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@AaronRobinsonMSFT

Copy link
Copy Markdown
Contributor Author

/cc @jkotas

@prmerger-automator

Copy link
Copy Markdown
Contributor

@AaronRobinsonMSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 26ea870:

💡 Validation status: suggestions

File Status Preview URL Details
docs/dotnet/how-to-access-characters-in-a-system-string.md 💡Suggestion Details

docs/dotnet/how-to-access-characters-in-a-system-string.md

  • Line 14, Column 7: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dotnet/standard/unsafe-code/best-practices#17-string-mutations' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Comment thread docs/dotnet/how-to-access-characters-in-a-system-string.md Outdated
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit fd8a0a2:

💡 Validation status: suggestions

File Status Preview URL Details
docs/dotnet/how-to-access-characters-in-a-system-string.md 💡Suggestion Details

docs/dotnet/how-to-access-characters-in-a-system-string.md

  • Line 14, Column 7: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dotnet/standard/unsafe-code/best-practices#17-string-mutations' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Comment thread docs/dotnet/how-to-access-characters-in-a-system-string.md Outdated
TylerMSFT
TylerMSFT previously approved these changes Jul 6, 2026
Comment thread docs/dotnet/how-to-access-characters-in-a-system-string.md Outdated
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit d80a502:

💡 Validation status: suggestions

File Status Preview URL Details
docs/dotnet/how-to-access-characters-in-a-system-string.md 💡Suggestion Details

docs/dotnet/how-to-access-characters-in-a-system-string.md

  • Line 14, Column 28: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dotnet/standard/unsafe-code/best-practices#17-string-mutations' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@AaronRobinsonMSFT

Copy link
Copy Markdown
Contributor Author

@TylerMSFT I keep the following warning. Do you know the relative link I can use instead?

Line 14, Column 28: [Suggestion] Absolute link 'https://learn.microsoft.com/dotnet/standard/unsafe-code/best-practices#17-string-mutations' will be broken in isolated environments. Replace with a relative link.

@TylerMSFT

Copy link
Copy Markdown
Collaborator

@TylerMSFT I keep the following warning. Do you know the relative link I can use instead?

Line 14, Column 28: [Suggestion] Absolute link 'https://learn.microsoft.com/dotnet/standard/unsafe-code/best-practices#17-string-mutations' will be broken in isolated environments. Replace with a relative link.

Try [17. String mutations](/dotnet/standard/unsafe-code/best-practices)

Comment thread docs/dotnet/how-to-access-characters-in-a-system-string.md Outdated
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 6804d51:

✅ Validation status: passed

File Status Preview URL Details
docs/dotnet/how-to-access-characters-in-a-system-string.md ✅Succeeded

For more details, please refer to the build report.

@AaronRobinsonMSFT

Copy link
Copy Markdown
Contributor Author

@TylerMSFT Thanks. Seems to be happy now. Ready for review.

@TylerMSFT TylerMSFT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Aaron.

@AaronRobinsonMSFT

Copy link
Copy Markdown
Contributor Author

@TylerMSFT Looks like I'm not able to push. This is ready from my perspective. Commit when convenient.

@v-dirichards

Copy link
Copy Markdown
Contributor

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Jul 7, 2026
@v-dirichards

Copy link
Copy Markdown
Contributor

@TylerMSFT I'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request.

@v-dirichards
v-dirichards merged commit fbd0d29 into MicrosoftDocs:main Jul 7, 2026
2 checks passed
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the patch-3 branch July 7, 2026 16:00
learn-build-service-prod Bot added a commit that referenced this pull request Jul 8, 2026
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#6756)

* Update Vectorized STL algorithm documentation to reflect the current stae (#5937)

Since the last update:
 * ARM64 and ARM64EC vectorization was added. Mention of x64 and x86 is removed, as vectorization is now supported on any target, except deprecated `/clr:pure` and `/clr:safe` modes.
 * `includes` is now manually vectorized too
 * `replace_copy` is now manually vectorized too

Also moved `find_end` to `search` / `search_n` group, where it fits better.

* Update header-files-cpp.md (#5938)

Clarify intent of section

* Update documentation on accessing System.String characters (#5940)

* Update documentation on accessing System.String characters

Added important note about treating interior pointers as const and linked to unsafe code best practices.

* Update docs/dotnet/how-to-access-characters-in-a-system-string.md

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

---------

Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com>
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
Co-authored-by: veganaiZe <7102064+veganaiZe@users.noreply.github.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
learn-build-service-prod Bot added a commit that referenced this pull request Jul 28, 2026
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#6778)

* Update Vectorized STL algorithm documentation to reflect the current stae (#5937)

Since the last update:
 * ARM64 and ARM64EC vectorization was added. Mention of x64 and x86 is removed, as vectorization is now supported on any target, except deprecated `/clr:pure` and `/clr:safe` modes.
 * `includes` is now manually vectorized too
 * `replace_copy` is now manually vectorized too

Also moved `find_end` to `search` / `search_n` group, where it fits better.

* Update header-files-cpp.md (#5938)

Clarify intent of section

* Update documentation on accessing System.String characters (#5940)

* Update documentation on accessing System.String characters

Added important note about treating interior pointers as const and linked to unsafe code best practices.

* Update docs/dotnet/how-to-access-characters-in-a-system-string.md

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Clarify version prefix for Visual Studio Command Prompt (#5946)

Updated instructions for starting Visual Studio Command Prompt to reflect changes in version specification.

---------

Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service LearnBuild@microsoft.com>
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
Co-authored-by: veganaiZe <7102064+veganaiZe@users.noreply.github.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Eric Brumer <ericbr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants