Repository navigation
Add Popup support for AppTheme - #664
Gerald Versluis (jfversluis) merged 3 commits into
Conversation
Added theming information and customization options for popups.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit dc109a0:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/docfx.json | Details | ||
| docs/windows/Extensions/DispatcherQueueTimerExtensions.md | View | Details | |
| docs/maui/views/Popup.md | ✅Succeeded | View |
docs/docfx.json
- Line 60, Column 45: [Warning: ms-service-subservice-invalid - See documentation]
Invalid value for 'ms.service': 'dotnet-communitytoolkit'.
docs/windows/Extensions/DispatcherQueueTimerExtensions.md
- Line 36, Column 1: [Warning: invalid-code]
The code snippet "~/../code-windows/components/Extensions/samples/Dispatcher/KeyboardDebounceSample.xaml" could not be found. - Line 38, Column 1: [Warning: invalid-code]
The code snippet "~/../code-windows/components/Extensions/samples/Dispatcher/KeyboardDebounceSample.xaml.cs" could not be found. - Line 42, Column 1: [Warning: invalid-code]
The code snippet "~/../code-windows/components/Extensions/samples/Dispatcher/MouseDebounceSample.xaml" could not be found. - Line 44, Column 1: [Warning: invalid-code]
The code snippet "~/../code-windows/components/Extensions/samples/Dispatcher/MouseDebounceSample.xaml.cs" could not be found.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit bdd4329: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
🟡 Changes recommended
The popup documentation incorrectly promises theme backgrounds for explicitly transparent colors, although the implementation preserves them only when BackgroundColor is unset.
1 open issue
What changed in this PR
Documents popup theme support and per-presentation customization in the .NET MAUI Community Toolkit, corresponding to CommunityToolkit/Maui#3345.
Changes:
- Adds light/dark background defaults and configuration examples.
- Explains theme-aware backgrounds for popups created from plain views.
- Documents the
OnInitializingcallback’s timing, usage, and exception behavior.
| File | Description |
|---|---|
docs/maui/views/Popup.md |
Adds popup theming guidance and per-presentation customization examples. |
Review effort: Balanced
Clarified behavior of popup background color in dark mode and theme awareness. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Gerald Versluis (@jfversluis) This PR is ready to merge |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit b0fe827: ✅ Validation status: passed
For more details, please refer to the build report. |
8f703b7
into
MicrosoftDocs:main
Brings in MicrosoftDocs#669 (camera-view.md: StartVideoRecording start-acknowledgment note) and MicrosoftDocs#664 (Popup.md: Theming). Popup.md conflict: - "Which value is used": only this branch adds it; kept. - Plain View TIP: kept this branch's rule (neither BackgroundColor nor Background) and main's point that a BackgroundColor of Colors.Transparent also replaces the theme-aware background. CommunityToolkit.Maui PopupPage.CreatePopupFromView binds both to the view, and BackgroundColorConverter uses any non-null color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Added theming information and customization options for popups.
This correlates to the work done in
CommunityToolkit.Maui: CommunityToolkit/Maui#3345