Skip to content

React package needs to pass network id param to Web3Services #719

Open

Description

@unspent-tx

Summary

The networkId is hard coded as 0, it should be options.networkId.

This was probably done because of a type error it didn't exist on options. New changes to SDK should fix this soon, not ready today.

https://github.com/MeshJS/mesh/blob/main/packages/mesh-react/src/cardano-wallet/web3-services.tsx#L30

Steps to reproduce the bug

No response

Actual Result

options.networkId.

Expected Result

options.networkId.

SDK version

latest

Environment type

  • Node.js
  • Browser
  • Browser Extension
  • Other

Environment details

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions