Repository navigation
Conversation
Mirrors detiler's existing config/custom-environment-variables.json mapping as a versioned schema instead of an ad-hoc node-config file, so the env-var-to-config mapping (including REDIS_KEY_PREFIX) is validated and typed like other MapColonies services.
Contributor
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/schemas": "https://ghatmpstorage.blob.core.windows.net/npm-packages/schemas-6f4826a49d1afd4c014c08d7ea86bb4fd4c1726f.tgz"
}
}The link will expire in a week ⌛ |
added 2 commits
October 21, 2026 10:45
keyPrefix always resolves (default ""), and detiler's code treats it as a non-optional string, so it should be required like the other structural redis fields.
ca/key/cert always resolve to a string (default ""), and detiler's connection-options builder calls readFileSync on them unconditionally when SSL auth is enabled, so they must be typed as required strings.
Contributor
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/schemas": "https://ghatmpstorage.blob.core.windows.net/npm-packages/schemas-f77ee6931cb85e16f14c1cf5b3594698048e5aa5.tgz"
}
}The link will expire in a week ⌛ |
Contributor
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/schemas": "https://ghatmpstorage.blob.core.windows.net/npm-packages/schemas-6553e2b6e6824397336215f46c8821b68f84e73f.tgz"
}
}The link will expire in a week ⌛ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schemas/vector/detiler/v1.schema.json, mirroring detiler's currentconfig/default.json/config/custom-environment-variables.jsonshape (openapiConfig, telemetry, server, redis) as a versioned schema instead of an ad-hoc node-config file.common/telemetry/logger/v1for the logger section; the redis section (includingREDIS_KEY_PREFIX) is defined inline since detiler's field names (keyPrefix,enableSslAuth,sslPaths,database) intentionally diverge fromcommon/redis.Test plan
npm run validatenpm run build(confirmsvectorDetilerV1/vectorDetilerV1Typeexport)npx prettier --check schemas/vector/detiler/v1.schema.json