Repository navigation
Refactor validation2 ix - #324
Merged
Merged
Conversation
`get_instrument_types` in shared/yamlsettings.py replaces the separate reads in the scope resolver and the projects, overview and admin pages. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
`KNOWN_VENDOR_NAMES` becomes `KNOWN_INSTRUMENT_TYPES`; comments, docstrings, test names, an error message and the texts of the projects page follow. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The page only knows the active versions, so "current + 1" was wrong whenever a newer version was archived or deleted. Add a test that the archive checkbox names the version `settings.create` archives, the latest active one. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…arams The gap is in that check, which every client and the processor run. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The field declares the lengths, the regex only the characters. A too short id now gets the length message, like a too long one. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Project.id and User.initials mixed a constant with a literal. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Only the projects page left it out; other clients could archive or delete it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The toasts no longer repeat the entered text; the bulk add report names the initials of the stored users. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review comments I