Skip to content

Refactor validation2 ix - #324

Merged
mschwoer merged 11 commits into
refactor_validation2_VIIfrom
refactor_validation2_IX
Nov 19, 2026
Merged

mschwoer merged 11 commits into
refactor_validation2_VIIfrom
refactor_validation2_IX

Conversation

@mschwoer

Copy link
Copy Markdown
Contributor

Address review comments I

mschwoer and others added 11 commits November 18, 2026 16:33
`get_instrument_types` in shared/yamlsettings.py replaces the separate reads
in the scope resolver and the projects, overview and admin pages.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
`KNOWN_VENDOR_NAMES` becomes `KNOWN_INSTRUMENT_TYPES`; comments, docstrings,
test names, an error message and the texts of the projects page follow.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The page only knows the active versions, so "current + 1" was wrong whenever
a newer version was archived or deleted. Add a test that the archive checkbox
names the version `settings.create` archives, the latest active one.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…arams

The gap is in that check, which every client and the processor run.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The field declares the lengths, the regex only the characters. A too short
id now gets the length message, like a too long one.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Project.id and User.initials mixed a constant with a literal.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Only the projects page left it out; other clients could archive or delete it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The toasts no longer repeat the entered text; the bulk add report names the
initials of the stored users.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mschwoer
mschwoer merged commit 899e2c0 into refactor_validation2_VII Nov 19, 2026
4 checks passed
@mschwoer
mschwoer deleted the refactor_validation2_IX branch November 19, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant