Skip to content

Replace winapi with windows-sys? #9

Closed

Description

@Jake-Shadle

I was updating mio to use windows-sys instead of winapi as windows-sys covers most of Windows API surface and most importantly is maintained and updated frequently as opposed to winapi, but this crate still provides types and functions not available in the windows-sys crate which is to be expected, however since it relies on winapi internally we'll be pulling in 2 versions of windows bindings, and in some cases need to transmute between the "same" type, so just wanted to open this issue to begin a discussion about whether this is something that would be acceptable to this project.

Activity

  1. Skgland commented on Mar 27, 2026

    @Skgland

    Why was this closed as completed?

  2. Jake-Shadle commented on Mar 27, 2026

    @Jake-Shadle
    Author

    I was pruning issues I'd opened that hadn't gotten any response or that I don't care about any longer.

  3. Skgland commented on Mar 27, 2026

    @Skgland

    Wouldn't closing as not planned be more appropriate then? (Maybe with a small comment)

    Image

    Would a PR doing the change still be appreciated?

  4. Jake-Shadle commented on Mar 27, 2026

    @Jake-Shadle
    Author

    It's not my repo, #17 already exists.

  5. Skgland commented on Mar 27, 2026

    @Skgland

    It's not my repo

    Ah, I overlooked that. A bit unfortunate that issue authors can't choose a different close reason.

    #17 already exists.

    Yeah, I saw that that PR exists, but it has merge conflicts and hasn't been updated in three years.

  6. Skgland commented on Mar 28, 2026

    @Skgland

    but it has merge conflicts and hasn't been updated in three years.

    Ah, I don't think the PR actually has blocking merge conflicts, GitHub UI is just contradicting itself.

    Can it be cleanly merged or are there conflicts that must be resolved!?

    Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions