Skip to content

HLLC hypoelastic energy block mis-doubles the theta-theta normal stress in 2D-axisymmetric (currently dead code) #1566

Description

@sbryngelson

Symptom: none today — the case validator restricts hypoelasticity to HLL, so HLLC's hypoelastic blocks are unreachable. If that restriction were lifted, 2D-axisymmetric hypoelastic HLLC runs would double a NORMAL stress as if it were shear.

Mechanism: HLLC's elastic-energy block uses the hard-coded shear test (i == 2) .or. (i == 4) .or. (i == 5) (src/simulation/m_riemann_solvers.fpp:1914, :2990 on master), but in 2D-axisymmetric the 4th stress component is theta-theta (normal). HLL's shear_indices-based test is dimension-correct.

Introduced: #727 (10b2209e7, 2024-12-20, @mrodrig6); it became physically meaningful when #815 added axisymmetric hypoelasticity and fixed only HLL. Tagging @mrodrig6 for context.

Fix: pending in the Phase-3 refactoring series (stacked on #1556): the dead HLLC blocks are deleted outright and the surviving HLL logic is unified into one helper using the shear_indices form.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions