Skip to content

[15.x] Run unit tests on .NET Framework in CI - #4678

Merged
jbogard merged 4 commits into
release/15.xfrom
ci/15x-netfx-tests
Nov 2, 2026
Merged

jbogard merged 4 commits into
release/15.xfrom
ci/15x-netfx-tests

Conversation

@jbogard

@jbogard jbogard commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

The UnitTests project adds a .NET Framework target only when IsWindows is true, but 15.x never defined IsWindows. Windows CI has silently tested only net9.0, and the net462 targets never built. They also didn't compile.

Backports main's .NET Framework test setup:

  • a06fbb8 defines IsWindows/IsMac in Directory.Build.props. Only that part is taken; its ci.yml artifact step is left out.
  • 3667a2b and 3c46449: test compile fixes for .NET Framework.
  • Adapted from 005a706: UnitTests targets net471 on Windows, and IntegrationTests drops its .NET Framework target, as on main.

Different from main: the AutoMapper project gets no .NET Framework target. Its old net462 target is removed; it never built and doesn't compile. 15.x packs on Ubuntu, so .NET Framework users get the netstandard2.0 build, and the net471 tests now run against exactly that build. The package contents don't change.

Verified on Windows 11 with CI's own steps (dotnet build -c Release, then dotnet test --no-build on UnitTests and DI.Tests):

Target Result
net9.0 1189 passed
net471 1187 passed
DI tests 29 passed

The two net471-only gaps are IReadOnlySet tests that don't exist on .NET Framework. The branch still builds on macOS.

🤖 Generated with Claude Code

jbogard and others added 4 commits November 1, 2026 11:54
(cherry picked from commit a06fbb8)
(cherry picked from commit 3667a2b)
Adapted from 005a706 on main. The UnitTests net471 target only builds
when IsWindows is defined, which the previous commits add. The AutoMapper
net462 target is removed: it never built, doesn't compile, and 15.x
packages on Ubuntu, so .NET Framework users get the netstandard2.0 build,
which is what the net471 tests now run against. IntegrationTests drops
.NET Framework, as on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 3c46449)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T17:58:41.789282Z d6aa800 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbogard
jbogard merged commit cb1d237 into release/15.x Nov 2, 2026
3 checks passed
@jbogard
jbogard deleted the ci/15x-netfx-tests branch November 2, 2026 14:48
AngeloDotNet added a commit to AngeloDotNet/CloudBudget that referenced this pull request Nov 16, 2026
Updated [AutoMapper](https://github.com/LuckyPennySoftware/AutoMapper)
from 15.1.3 to 15.1.4.

<details>
<summary>Release notes</summary>

_Sourced from [AutoMapper's
releases](https://github.com/LuckyPennySoftware/AutoMapper/releases)._

## 15.1.4

## Security

This release fixes two denial-of-service vulnerabilities. In both,
deeply nested input could bypass `MaxDepth` and exhaust the stack. The
resulting `StackOverflowException` can't be caught, so it ends the
process. Please upgrade if your application maps untrusted, deeply
nested data.

-
[GHSA-6vhm-j9h7-f9gh](GHSA-6vhm-j9h7-f9gh):
`MaxDepth` wasn't enforced when mapping through constructor parameters,
including positional records. Thanks to @​mcambria for the report.
-
[GHSA-gpwp-5797-mjff](GHSA-gpwp-5797-mjff):
other recursion paths bypassed `MaxDepth`: derived maps, `object` and
interface members, dictionary and dynamic sources, and recursive type
converters.

CVE IDs have been requested and will be added here once they're
assigned.

## Behavior changes

- Recursion that `MaxDepth` can't limit now throws a catchable
`InsufficientExecutionStackException` instead of crashing the process.
- Derived maps (`Include` / `IncludeBase`) now inherit `MaxDepth` and
get the default limit of 64 for self-referential maps. If your
polymorphic graphs legitimately go deeper, set `MaxDepth` explicitly.
- Constructor mapping now stops at the same depth as property mapping.

## Other fixes

- Fixed `Context.Items are only available...` exceptions with
`MaxDepth`, which depended on registration or warmup order (#​4651,
backported in #​4676)

## What's Changed
* [15.x] Fail the release when the tag is not on its release branch by
@​jbogard in LuckyPennySoftware/AutoMapper#4669
* [15.x] Emit the context check for the containing type map in
CollectionMapper by @​jbogard in
LuckyPennySoftware/AutoMapper#4676
* [15.x] Run unit tests on .NET Framework in CI by @​jbogard in
LuckyPennySoftware/AutoMapper#4678


**Full Changelog**:
LuckyPennySoftware/AutoMapper@v15.1.3...v15.1.4

Commits viewable in [compare
view](LuckyPennySoftware/AutoMapper@v15.1.3...v15.1.4).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=AutoMapper&package-manager=nuget&previous-version=15.1.3&new-version=15.1.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/AngeloDotNet/CloudBudget/network/alerts).

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant