Repository navigation
[15.x] Run unit tests on .NET Framework in CI - #4678
Merged
Merged
Conversation
(cherry picked from commit a06fbb8)
(cherry picked from commit 3667a2b)
Adapted from 005a706 on main. The UnitTests net471 target only builds when IsWindows is defined, which the previous commits add. The AutoMapper net462 target is removed: it never built, doesn't compile, and 15.x packages on Ubuntu, so .NET Framework users get the netstandard2.0 build, which is what the net471 tests now run against. IntegrationTests drops .NET Framework, as on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 3c46449)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 6, 2026
This was referenced Nov 13, 2026
This was referenced Nov 15, 2026
AngeloDotNet
added a commit
to AngeloDotNet/CloudBudget
that referenced
this pull request
Nov 16, 2026
Updated [AutoMapper](https://github.com/LuckyPennySoftware/AutoMapper) from 15.1.3 to 15.1.4. <details> <summary>Release notes</summary> _Sourced from [AutoMapper's releases](https://github.com/LuckyPennySoftware/AutoMapper/releases)._ ## 15.1.4 ## Security This release fixes two denial-of-service vulnerabilities. In both, deeply nested input could bypass `MaxDepth` and exhaust the stack. The resulting `StackOverflowException` can't be caught, so it ends the process. Please upgrade if your application maps untrusted, deeply nested data. - [GHSA-6vhm-j9h7-f9gh](GHSA-6vhm-j9h7-f9gh): `MaxDepth` wasn't enforced when mapping through constructor parameters, including positional records. Thanks to @mcambria for the report. - [GHSA-gpwp-5797-mjff](GHSA-gpwp-5797-mjff): other recursion paths bypassed `MaxDepth`: derived maps, `object` and interface members, dictionary and dynamic sources, and recursive type converters. CVE IDs have been requested and will be added here once they're assigned. ## Behavior changes - Recursion that `MaxDepth` can't limit now throws a catchable `InsufficientExecutionStackException` instead of crashing the process. - Derived maps (`Include` / `IncludeBase`) now inherit `MaxDepth` and get the default limit of 64 for self-referential maps. If your polymorphic graphs legitimately go deeper, set `MaxDepth` explicitly. - Constructor mapping now stops at the same depth as property mapping. ## Other fixes - Fixed `Context.Items are only available...` exceptions with `MaxDepth`, which depended on registration or warmup order (#4651, backported in #4676) ## What's Changed * [15.x] Fail the release when the tag is not on its release branch by @jbogard in LuckyPennySoftware/AutoMapper#4669 * [15.x] Emit the context check for the containing type map in CollectionMapper by @jbogard in LuckyPennySoftware/AutoMapper#4676 * [15.x] Run unit tests on .NET Framework in CI by @jbogard in LuckyPennySoftware/AutoMapper#4678 **Full Changelog**: LuckyPennySoftware/AutoMapper@v15.1.3...v15.1.4 Commits viewable in [compare view](LuckyPennySoftware/AutoMapper@v15.1.3...v15.1.4). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/AngeloDotNet/CloudBudget/network/alerts). </details>
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UnitTests project adds a .NET Framework target only when
IsWindowsis true, but 15.x never definedIsWindows. Windows CI has silently tested only net9.0, and the net462 targets never built. They also didn't compile.Backports main's .NET Framework test setup:
IsWindows/IsMacinDirectory.Build.props. Only that part is taken; itsci.ymlartifact step is left out.Different from main: the AutoMapper project gets no .NET Framework target. Its old net462 target is removed; it never built and doesn't compile. 15.x packs on Ubuntu, so .NET Framework users get the netstandard2.0 build, and the net471 tests now run against exactly that build. The package contents don't change.
Verified on Windows 11 with CI's own steps (
dotnet build -c Release, thendotnet test --no-buildon UnitTests and DI.Tests):The two net471-only gaps are
IReadOnlySettests that don't exist on .NET Framework. The branch still builds on macOS.🤖 Generated with Claude Code