fix: incorrect file names in doc.json - #3070
Merged
Merged
Conversation
AndreasMatthias
force-pushed
the
fix_doc_filenames
branch
from
February 12, 2025 22:01
9e11f38 to
1076f09
Compare
File names in doc.json were broken since LuaLS#2821. See discussion LuaLS#2971.
AndreasMatthias
force-pushed
the
fix_doc_filenames
branch
from
February 12, 2025 22:02
1076f09 to
2266b94
Compare
Contributor
Author
|
Please, do not merge it. There are still some open issues. I'm working on it. |
Contributor
You can convert the PR into draft such that maintainers will know that it is not ready |
The test `relativePath:sub(1, 2) == '..'` doesn't work on windows if the paths are on different drives.
AndreasMatthias
marked this pull request as draft
February 13, 2025 17:36
AndreasMatthias
marked this pull request as ready for review
February 14, 2025 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2971
File names in doc.json were broken since #2821.