fix: use theme color for file mention category icon - #1237
Merged
Merged
Conversation
Contributor
|
Desktop PR regression failed on commit
Recordings not attached
The Actions artifact retains the complete trace, screenshots, logs, and runtime evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
The Files category in the mention menu used a file asset with a fixed blue-gray stroke, so it differed from the other category icons and ignored the menu's highlighted color.
Summary
Render the Files category with Lucide's monochrome File icon, using the same size, stroke width, and inherited menu color as the other categories. Individual file candidates retain their file-type icons.
Visual explanation
Simple change: one category glyph changes its rendering source; the menu structure and behavior are unchanged.
Before / after
Test plan
git diff --check.vitestmissing),pnpm check(tsgomissing), andpnpm format(oxfmtmissing). This nested checkout has no installed dependencies.pnpm run docs statusandpnpm run docs check; the latter reports existing broken links, including absent ACP submodule files.