Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

fix: ensure user prefs return correct values - #298

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix-ensure-user-prefs-return-correct-values
Jul 24, 2024
Merged

ReenigneArcher merged 1 commit into
masterfrom
fix-ensure-user-prefs-return-correct-values

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

If a value was set to a non default value, the prefs kit would still return the default value.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov

codecov Bot commented Jul 24, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (5e21cdf) to head (ae9dc9c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.01%     
==========================================
  Files          24       24              
  Lines        2869     2863       -6     
==========================================
- Hits         2260     2255       -5     
+ Misses        609      608       -1     
Flag Coverage Δ
Python-2.7-Linux 78.76% <ø> (-0.01%) ⬇️
Python-2.7-Windows ?
Python-2.7-macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plexhints/prefs_kit.py 85.63% <ø> (+0.07%) ⬆️

@ReenigneArcher
ReenigneArcher force-pushed the fix-ensure-user-prefs-return-correct-values branch from 141f32c to ae9dc9c Compare July 24, 2024 23:28
@ReenigneArcher
ReenigneArcher merged commit d434893 into master Jul 24, 2024
@ReenigneArcher
ReenigneArcher deleted the fix-ensure-user-prefs-return-correct-values branch July 24, 2024 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant