Make hotkeys work reliably in the pop-out window - #1160
Open
rahul-muthu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Hotkeys could stop working when the pop-out timer window had focus.
The pop-out window now forwards keyboard input to the existing browser hotkey handler. This includes modifier keys and numpad keys. The handler is connected as soon as the pop-out opens, so shortcuts also work while the window is still loading.
Desktop hotkeys are left unchanged because they are already global, and adding another listener there could trigger commands twice.
Testing
Numpad1to start the timer