Skip to content

fix(packaging): include requirements/*.txt in sdist so litdata[extras] works - #951

Open
deependujha wants to merge 3 commits into
Lightning-AI:mainfrom
deependujha:fix/manifest-include-requirements
Open

deependujha wants to merge 3 commits into
Lightning-AI:mainfrom
deependujha:fix/manifest-include-requirements

Conversation

@deependujha

Copy link
Copy Markdown
Collaborator
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

MANIFEST.in had a typo (*.tx;t) so requirements/ was never packaged
into the sdist. Since python -m build builds the wheel from the sdist,
setup.py's _prepare_extras() found no files and the published wheels
shipped without the extras extra.

❯ uv pip install "litdata[extras]"                                                                                                                                                                                          ─╯
Resolved 29 packages in 63ms
Installed 1 package in 13ms
 + litdata==0.2.76
warning: The package `litdata==0.2.76` does not have an extra named `extras`

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82%. Comparing base (c6f075c) to head (dba1aa8).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #951   +/-   ##
=====================================
  Coverage     82%     82%           
=====================================
  Files         72      72           
  Lines      16445   16445           
=====================================
  Hits       13505   13505           
  Misses      2940    2940           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fail the release build if requirements/*.txt is missing from the sdist, and run it on PRs that touch packaging files.

@bhimrazy bhimrazy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a ci check step too.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants