Migrate remaining matplotlib pop-ups to Panel - #401
Merged
Conversation
Replace the Step 3 (preprocessing/artifact-removal) and Step 4 (transient-peak) matplotlib/TkAgg pop-up windows with Panel pages served in the browser, the last non-Panel GUI in GuPPy. - New serve_blocking_page helper (frontend_utils) serves a page on a background Bokeh server and blocks the worker subprocess on a threading.Event until the user continues or closes the tab, preserving the existing block-then-continue flow (home.py unchanged). - ArtifactRemovalWidget (keyboard-driven Tk figure) becomes ArtifactRemovalConfig: an editable per-recording-site (start, end) good-chunk table shaded live as hv.VSpans; save writes the same coordsForPreProcessing_<site>.npy format fetchCoords consumes. - z-score/dF-F, artifact-removal review, and transient-peak plots become read-only HoloViews pages; visualization/* builders now return hv objects. - All visualization stays behind is_headless(); matplotlib remains only for colormap names in the Step 5 dashboard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
The step launcher ran the whole step synchronously on the Panel server's
IOLoop — a busy-wait progress poll plus thread.join — freezing the main app
for the entire step. With the pop-ups now served as in-browser Panel pages,
that block spans the interactive wait, so the main tab's websocket drops
("server connection lost") and never recovers.
Poll progress from a periodic callback on the IOLoop instead: the worker still
runs in a background thread, but the click handler returns immediately and the
app keeps answering heartbeats. Replaces the blocking readPBIncrementValues
with a non-blocking read_progress_snapshot + poll_progress_step.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…r connection lost bug.
…r connection lost bug.
pauladkisson
marked this pull request as ready for review
July 27, 2026 16:53
pauladkisson
enabled auto-merge
July 27, 2026 16:55
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step for #147
Follow-up: Optimize Artifact Removal Process #402