Conversation
Author
|
Snagged the bench script from #1 (comment) and ran it on this. Results: |
Author
|
Results with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store a permanent reference to the lock shm object instead of using the memo table with the lock keys. Reduces the size+churn on the memo table by 50%.
This is greatly optimizes the happy path (when the lock is explicitly
unlock()-ed by the caller and not by gc) because no table operations are done during garbage collection in this case. This makesresty.lockmuch less susceptible to memo table fragmentation.