fix(udp): validate HELLO before latch (Fixes #616) - #652
Open
Kiryuumaru wants to merge 1 commit into
Open
Kiryuumaru wants to merge 1 commit into
Kiryuumaru wants to merge 1 commit into
Conversation
Spoofed or stray first datagram could latch Connect(remote) and consume the one-shot accept slot, denying the real client. Extract HELLO validation into UdpHandshake and gate latch/consume on valid HELLO; stray packets no longer hijack the slot. Add UdpHandshakeHardeningTests (stray-packet pin) and UdpHandshakeAcceptanceTests (real-client handshake). Updates docs/transports/udp.md handshake contract. Fixes #616.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security fix for #616: UDP HELLO latch spoof. The server accept path latched Connect(remote) to the first inbound datagram source before validating its content, so a spoofed or stray HELLO could hijack and lock the single accept slot, denying the real client.
Changes
Linkage
Fixes #616.
Evidence
Full UDP integration suite green: 33/33 PASS (dotnet test tests/NetConduit.Transport.Udp.IntegrationTests/, net10.0, Duration ~7s), superseding the prior 28/28 report — 5 new tests added by this change, zero failures.