mux: framing read deadlines + bounded payload growth (Fixes #617 — slowloris stall) - #650
Open
Kiryuumaru wants to merge 3 commits into
Open
Kiryuumaru wants to merge 3 commits into
Kiryuumaru wants to merge 3 commits into
Conversation
Slowloris-style stall: frame/payload reads had no read deadline, letting a trickling peer hold a stream open indefinitely. Adds MultiplexerOptions.FrameReadTimeout plus payload growth rate knob; StreamMultiplexer reader loop enforces deadlines with incremental bounded growth; MuxHandshake passes timeouts through with growth. Tests: FramePayloadLivenessTests (14/14). Docs: ADR-0002 plus framing-protocol, multiplexer-options, scope updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #617.
Slowloris-style stall: frame and payload reads had no read deadline, letting a trickling peer hold a stream open indefinitely.
What this changes:
Tests: FramePayloadLivenessTests, 14/14 passing. Full suite and multi-TFM build green prior to commit.
Docs: ADR-0002 plus framing-protocol, multiplexer-options, and scope updates.