Skip to content

new examples - #57

Merged
ViralBShah merged 7 commits into
JuliaSparse:v11from
samuel-esp:new-examples
Oct 27, 2026
Merged

ViralBShah merged 7 commits into
JuliaSparse:v11from
samuel-esp:new-examples

Conversation

@samuel-esp

@samuel-esp samuel-esp commented Sep 12, 2021 •

Copy link
Copy Markdown
Contributor

new examples added, new files could still contain some print statements used to test the algorithms

@rayegun

rayegun commented Oct 31, 2021 •

Copy link
Copy Markdown
Member

Sorry I lost track of this. If you're still interested in this would you mind doing a couple things for me?

  1. Adding one or two tests for each algorithm
  2. Adding a link to the paper/wikipedia/etc.

If not I will of course finish these up and merge once I have the time to test them :).

One of the changes I just made requires a change to master (which I overlooked previously) which I will do in a moment.

@codecov-commenter

codecov-commenter commented Oct 31, 2021 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.87%. Comparing base (7cf693a) to head (312c988).

Additional details and impacted files
@@            Coverage Diff             @@
##              v11      #57      +/-   ##
==========================================
+ Coverage   65.65%   65.87%   +0.22%     
==========================================
  Files          54       54              
  Lines        4449     4449              
==========================================
+ Hits         2921     2931      +10     
+ Misses       1528     1518      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuel-esp

Copy link
Copy Markdown
Contributor Author

No worries! I have some tests ready on my other repository, just give some days that I'm currently busy with midterms and i'll work on this

@ViralBShah
ViralBShah changed the base branch from master to v11 October 27, 2026 14:23
samuel-esp and others added 7 commits October 27, 2026 15:37
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Use `*(A, B, op; mask)`, `Structural`/`Complement` masks and
  `Descriptor(...)` in place of the removed `mul`, `Semirings.*`,
  `Descriptors.*` and `TRIU`/`TRIL` APIs; drop debug prints.
- BFS: use `fill=nothing` so missing entries read as `nothing`, seed the
  frontier with the source index rather than 1 (parents were wrong for
  any source other than 1), and replace `filter` on a GBVector.
- Prim: `argmin` now returns a linear index; the old code relaxed with
  row `u[1]` (always 1) instead of the selected vertex.
- Floyd-Warshall: combine with `eadd` (union) instead of `emul`, and
  return the distance matrix rather than the last outer product.
- K-truss: iterate until the edge count stops changing.
- CDLP: drop the DataStructures dependency and compute the mode of the
  neighbour labels directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turn the `@repl` blocks in index.md, arrays.md, unaryops.md and
binaryops.md into `jldoctest` blocks with outputs generated by
`doctest(...; fix=true)`. Random inputs in arrays.md are replaced with
small deterministic ones. Printed memory sizes and operator pointer
addresses are filtered since they vary across runs and platforms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ViralBShah

Copy link
Copy Markdown
Member

Rebased onto v11 (0.12 / GraphBLAS 10.5) and finished per the review:

  • Each example has a reference link in its header, works with the current API, and has its debug prints removed.
  • test/examples.jl adds small hand-checked tests.
  • Testing found and fixed a few bugs: BFS parents with a source other than 1, Prim relaxing from the wrong row, and Floyd-Warshall using emul and returning the wrong matrix.
  • The @repl examples in docs/src are now doctests, with filters for printed memory sizes and pointers.
  • Not yet handled: CDLP still fails on graphs with isolated vertices.

@ViralBShah
ViralBShah merged commit 450ca8b into JuliaSparse:v11 Oct 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants