This repository was archived by the owner on May 20, 2021. It is now read-only.
Repository navigation
Conversation
JohnSundell
reviewed
Jun 6, 2017
JohnSundell
left a comment
JohnSundell
left a comment
Owner
There was a problem hiding this comment.
Hey @wojtkow! Thanks for contributing to Wrap, and sorry for taking a long time to review this. Could you please update the code formatting to match the rest of Wrap? Also remove undesired whitespace? 🙂
Owner
|
Closing due to inactivity. |
Owner
|
I should clarify that I'm still very open to merging this (or another PR adding similar functionality) into Wrap - as long as the change fits in code style-wise with the rest of the project 🙂 |
|
@JohnSundell This seems more reasonable than #52, I can make a PR if no one is interested in that 😄 |
This was referenced Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added proposed fallbackValueForProperty function to WrapCustomizable.
This function allows to return own value in case of nil value of properties in wrapped object.