chore: delete the excluded rhiza stubs instead of freezing them - #94
Merged
Conversation
.rhiza/template.yml excludes these three paths so no sync reinstates or deletes them, but exclusion only stops the sync touching a file -- it does not remove it. That left the two workflow callers pinned to `uses: ...@v1.3.4` for good: no future sync will bump them, so "inert and frozen" was the steady state. Deleting them sidesteps the frozen pin entirely, and the exclusions stay in place to keep them from coming back. Nothing is lost. Both workflows are opt-in stubs that skip unless a repository variable turns them on, and `gh variable list` is empty -- neither MUTATION_ENABLED nor FUZZING_ENABLED is set. Neither is a required status check in .github/rulesets/main-branch-protection.json. Re-enabling either was always two steps (set the variable, restore the caller); it stays two steps. .github/CONFIG.md goes for the same reason it was excluded: it no longer exists upstream at v1.4.2, and CLAUDE.md and the README are where this repo's contributor guidance lives. It follows .github/ISSUE_TEMPLATE and .github/DISCUSSION_TEMPLATE, removed in f98755e and #93. Also drop SECURITY.md's ClusterFuzzLite bullet. It claimed fuzz targets run on pull requests and scheduled batch runs, which was never true here: FUZZING_ENABLED is unset *and* the .clusterfuzzlite/ config the reusable workflow requires does not exist, so the job has only ever skipped. Removing the caller makes it permanently false, and a security policy overstating its own coverage is worse than one that says less. `make mutation` still runs mutmut locally -- that task belongs to rhiza-task, not to the deleted caller. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes previously excluded Rhiza “stub” files so they don’t remain permanently frozen (e.g., with outdated reusable-workflow pins), and corrects repo security documentation to avoid overstating fuzzing coverage.
Changes:
- Deleted the two excluded, opt-in Rhiza workflow callers (
rhiza_mutation.yml,rhiza_fuzzing.yml) rather than leaving them frozen. - Deleted the excluded
.github/CONFIG.mddoc stub that no longer exists upstream. - Updated
SECURITY.mdto remove the (previously inaccurate) fuzzing claim.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
SECURITY.md |
Removes the fuzzing bullet so the documented security measures match what’s actually enabled/configured in this repo. |
.github/workflows/rhiza_mutation.yml |
Deletes an excluded Rhiza workflow caller stub to avoid a permanently frozen reusable-workflow pin. |
.github/workflows/rhiza_fuzzing.yml |
Deletes an excluded Rhiza workflow caller stub to avoid a permanently frozen reusable-workflow pin. |
.github/CONFIG.md |
Removes a stale, excluded documentation stub that is no longer present upstream. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #92. Deletes the three paths that PR excluded, rather than leaving them
frozen.
Why deleting, not just excluding
exclude:stops the sync touching a file — it does not remove it. For the twoworkflow callers that meant their
uses: …@v1.3.4pin was frozen permanently: nofuture sync will ever bump it. "Inert and frozen" is a worse steady state than
"absent", so they go. The
exclude:entries stay exactly as they are, and are nowwhat stops the files coming back.
Verified: re-running
scripts/sync.pyagainst v1.4.2 after the deletions reports"Template unchanged since last sync — nothing to apply", leaves all three files
deleted, and leaves the tree clean. The exclusions hold.
Nothing is lost
Both workflows are opt-in stubs that skip unless a repository variable enables them:
gh variable listis empty — neitherMUTATION_ENABLEDnorFUZZING_ENABLEDis set, so both have only ever skipped.
.github/rulesets/main-branch-protection.json.stays two steps.
make mutationstill runs mutmut locally — that task belongs torhiza-task, not tothe deleted caller.
.github/CONFIG.mdgoes for the reason it was excluded: it no longer exists upstreamat v1.4.2, and CLAUDE.md and the README are where this repo's contributor guidance
lives. It follows
.github/ISSUE_TEMPLATEand.github/DISCUSSION_TEMPLATE(f98755e,#93).
One documentation fix found on the way
SECURITY.mdclaimed:That has never been true in this repo, for two independent reasons:
FUZZING_ENABLEDis unset, and the
.clusterfuzzlite/config the reusable workflow requires does notexist. Removing the caller makes it permanently false, and a security policy that
overstates its own coverage is worse than one that says less — so the bullet is gone.
SECURITY.mdis repo-owned (absent from.rhiza/template.lock), so this edit is nottemplate drift. I did not audit its other bullets; that's a separate pass if you want
one.
Correction to #92's description
#92's body justified restoring the
Makefileshim partly by claiming a missingMakefile would turn the required
Pre-commit hookscheck red. That was wrong, andthis PR is a good place to record it:
rhiza_ci.ymlrunsuvx "$RHIZA_TASK" <gate>for every gate,fmtincluded — nothing shells out tomake.rhiza-hooksv1.2.0 gatesupdate-readme-helponfiles: ^Makefile$andcheck-makefile-targetson(^Makefile$|^\.rhiza/.*\.mk$). With no Makefile thereare no matched files, so both skip — and a skip is a pass.
Restoring the shim was still right, on the other grounds #92 gave: README and
CLAUDE.md both document
make test/make fmt/make typecheck, so it keeps thedocumented front door working. Ergonomic, not load-bearing for CI.
🤖 Generated with Claude Code