Skip to content

Document root cause of Bug_catching_up flake (part of #5696) - #5822

Merged
jeremydmiller merged 1 commit into
masterfrom
stoat/nov-5-releases/marten-5696
Nov 5, 2026
Merged

jeremydmiller merged 1 commit into
masterfrom
stoat/nov-5-releases/marten-5696

Conversation

@jeremydmiller

Copy link
Copy Markdown
Member

Part of #5696.

Root cause, from reading JasperFx (not reproduced locally): CatchUpAsync collects failures through a Recorder on Database.Tracker. ShardStateTracker.PublishAsync records state synchronously but delivers to listeners through an async Block<ShardState>, and throwIfRecordedExceptions reads the recorder right after ReportCriticalFailureAsync. If the block hasn't delivered yet, CatchUpAsync returns cleanly. Not leftover state: the schema is per class and dropped per test.

This PR only corrects the comments on both tests. Comment-only change; the Retry traits stay.

Left: fix in JasperFx (drain tracker or read the agent failure before checking), adopt the release, then remove both Retry traits and verify with --disable-test-retry.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jeremydmiller
jeremydmiller merged commit f5a6f33 into master Nov 5, 2026
@jeremydmiller
jeremydmiller deleted the stoat/nov-5-releases/marten-5696 branch November 5, 2026 19:58
This was referenced Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant