Repository navigation
Document root cause of Bug_catching_up flake (part of #5696) - #5822
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
Closed
This was referenced Nov 13, 2026
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5696.
Root cause, from reading JasperFx (not reproduced locally):
CatchUpAsynccollects failures through aRecorderonDatabase.Tracker.ShardStateTracker.PublishAsyncrecords state synchronously but delivers to listeners through an asyncBlock<ShardState>, andthrowIfRecordedExceptionsreads the recorder right afterReportCriticalFailureAsync. If the block hasn't delivered yet,CatchUpAsyncreturns cleanly. Not leftover state: the schema is per class and dropped per test.This PR only corrects the comments on both tests. Comment-only change; the Retry traits stay.
Left: fix in JasperFx (drain tracker or read the agent failure before checking), adopt the release, then remove both Retry traits and verify with --disable-test-retry.
🤖 Generated with Claude Code