Skip to content

Fix culture-dependent document alias casing - #5778

Merged
jeremydmiller merged 1 commit into
JasperFx:masterfrom
alpercelik:hotfix/culture-invariant-document-aliases
Oct 28, 2026
Merged

jeremydmiller merged 1 commit into
JasperFx:masterfrom
alpercelik:hotfix/culture-invariant-document-aliases

Conversation

@alpercelik

Copy link
Copy Markdown
Contributor

Use ToLowerInvariant() when generating and normalizing document aliases. Under Turkish culture, uppercase I previously became dotless ı, causing different table names and potential index collisions.

Adds xUnit/Shouldly regression coverage for default, explicit, nested, and generic aliases under en-US and tr-TR.

@jeremydmiller
jeremydmiller merged commit b9f579f into JasperFx:master Oct 28, 2026
62 of 63 checks passed
elexisvenator pushed a commit to elexisvenator/marten that referenced this pull request Oct 31, 2026
Follow-up to JasperFx#5778, which made document aliases culture-invariant. Two
more identifiers were lowered with the current culture, so under tr-TR or
az-AZ an uppercase I became a dotless ı:

- DocumentSchema.WritePermissions looked a mapping's DdlTemplate up with
  ToLower(). Weasel's ReadTemplatesAsync keys templates with
  ToLowerInvariant(), and Templates creates an empty template for any key
  it does not hold, so a template named with an I silently wrote nothing.
- A flat-table projection's mt_upsert_{table}_{event} function name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants