Repository navigation
docs(contributing): heading casing per the #719 ruling - #971
Conversation
4a739d4 to
c7f3fd6
Compare
|
The 22 rewrites,
Two kept deliberately as-is rather than reworded: `Why a Class and Not ``object()``` |
c7f3fd6 to
2dc35a5
Compare
|
NEEDS CHANGES at I claimed exactly one stale cross-reference survived the rename. There were
My sweep was scoped to a hand-picked list of 8 strings; my second sweep also A prose break the rename caused, Two headings misdescribed their sections, both renamed:
62 underlines re-checked, zero short. 57 tests OK. Note the PR now touches |
…ce-shaped ones (#719) - Re-cased 16 already-short headings to Title Case across pep.rst, releasing.rst, testing.rst, workflows.rst, and conventions/{mint-criterion,sentinel-convention}.rst. - Rewrote 22 sentence-shaped headings into short noun phrases, matching the 2026-10-01 ruling that a sentence should not be used as a title at all. - Left 24 headings unchanged (already Title Case, no rewrite needed). - Updated the implicit-hyperlink cross-references in releasing.rst and workflows.rst that pointed at renamed heading text. Underline lengths re-adjusted to match every renamed heading, verified with a docutils parse (no "Title ... too short" errors). tests/project/test_conventions_doc_claims.py pins none of the renamed heading strings, so it needed no edits; both pytest (37 passed, 1 skipped) and plain unittest (38 ran, OK) confirm.
2dc35a5 to
4308d62
Compare
|
NEEDS CHANGES at Rewrapping that paragraph with Now 82 / 41 / 84 / 84. Swept every added Round 2 independently confirmed the substance, having re-derived rather than It flagged the test run as
|
|
GOOD TO GO at Verified on my side rather than relayed: Two methodological notes from the review worth keeping, both of which would have
It also found a pre-existing 99-character prose line at Honest about its own gap, which I'd rather have than a false corroboration: its
|
|
The red mark here is an infrastructure stall, not this diff. Root-caused rather
On the same run ( Filed as #974 with the fix — apt retries and timeouts, plus a step-level cap. I am not |
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
First slice of the heading ruling on #719, covering
docs/source/contributing/.62 headings in scope: 24 already correct, 16 re-cased, 22 rewritten. The
rewrites are the substance — the ruling is not a casing rule. A heading like
What a Failed Lookup Raiseswas already Title Case and still broke it, being aclause rather than a title; it is now
Failed-Lookup Exceptions. The fullold → newlist is in a comment below, since it is the reviewable part and doesnot belong in the body.
The dividing line used: a finite verb makes it a sentence and earns a rewrite; a
gerund or infinitive phrase is a noun phrase and only needs casing, so
Running the tests→Running the Testsrather than being reworded.Headings are link targets, so five implicit
`Text`_references wererepointed in
releasing.rstandworkflows.rst, and one stale docstring quotecorrected in
tests/corekit/test_sentinel_exports_unit.py:420. Every underlinere-measured against its new text: 62 checked, zero shorter than their heading.
No test assertion changed —
test_conventions_doc_claims.pyslices on.. _label:anchors and
list-tablemarkers, never heading text. Six coupled modules green.