Repository navigation
ci(experimental): pass the Windows leg's ignore list as an argument file (#2678) - #2681
Merged
Merged
Conversation
…ile (#2678) The windows job's Run unit tests step passed an --ignore per LATEST-tier module on the command line, which outgrew Windows' command-line limit: Git Bash could not start python (Argument list too long, exit 126) and pytest never ran. - The step writes each module as an --ignore line of $RUNNER_TEMP/latest-tier.args and hands pytest "@$args"; pytest's parser reads @ files, and xdist workers re-parse the same command line. The runner's D:\a\_temp form needs no cygpath: Git Bash passes it unchanged, as it already does --junitxml's. The flag block stays as test's. - The argv pin asserts the @ argument, and the argv as pytest expands it, so a LATEST module missing from the file still fails it. - workflows.rst's Windows-leg paragraph says how the ignores are passed. Windows-leg, shellcheck, conventions-claims and workflow-reading project modules and the tier guard pass; actionlint is clean.
JarryShaw
added
ci
Owner
Author
|
GOOD TO GO at
|
JarryShaw
added
review: good-to-go
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…h refusals and the Windows leg's argument file into 1.6.0 (#2449) - Breaking: MH(raw) and TCP(raw) (#2683) raise ProtocolError for an MH message whose Header Len is short of its fields, or a DSS option of a length its flags do not give, where 1.5.x read the gap as zeros and rebuilt it longer; a cut MH keeps its declared Header Len. The entry gives the old and new results, measured against v1.5.1. - Folded into unreleased entries: radiotap's decoded optional fields, Radiotap.__field__ with register_field and register_radiotap_field, the RadiotapField schemas and pcapkit.const.radiotap with its crawlers (#2657), and cut TLV items decoding zero-padded (#2690), into the Radiotap entry, with the IEEE 802.11 entry's Flags clause corrected; #2657's ruling on code to layout tables, into the conventions entry; the Windows leg's argument file (#2681), into the CI legs entry, as the cycle's other CI changes have entries. - No entry for the test-only 42a6133. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
From
61092a529on,Python 3.15 on Windows (experimental)fails before pytest starts, withArgument list too longand exit 126. Thewindowsjob'sRun unit testsstep passed one--ignore=<module>per LATEST-tier module on the command line, and that list has grown past Windows' command-line limit.The step now writes the ignores one per line to
$RUNNER_TEMP/latest-tier.argsand runspython -m pytest "$@" "@$args". pytest's parser reads@-prefixed files, and xdist workers re-parse the same argv. Git Bash passes@D:\a\_temp/…through unchanged, the same form--junitxmlalready uses on this leg. The flag block and the Linux legs are unchanged.test_windows_test_leg_2060.py's pin now checks both the literal argv and the argv as pytest expands the file. It fails if a LATEST-tier module stops being ignored. workflows.rst's Windows-leg paragraph is updated to match. This PR's own run of the leg is the real-runner check.Closes #2678