Repository navigation
fix(link): honour a stop at LinuxSLL on its ARPHRD registry path - #2587
Merged
Merged
Conversation
- LinuxSLL._import_next_layer checks _sigterm before the arphrd_type registry lookup, as Protocol._import_next_layer does, so a parse told to stop at LinuxSLL (layer='Link', protocol='LinuxSLL', the version's name or class) keeps a FRAD, GRE, Radiotap or Netlink payload Raw instead of dispatching it. The EtherType path already stopped. - The stopped Raw records protocol_type, as a registered Raw entry does. - Replace the pin of the old order with tests of every stop form on both versions and both paths, a stop elsewhere that still dispatches, and the same through pcapkit.extract.
JarryShaw
added
fix
Owner
Author
|
GOOD TO GO at
|
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…1.6.0 (#2449) - Added: DCCP, its checksum over the IP pseudo-header, register_dccp and register_dccp_option, and the pcapkit.const.dccp registries (#2593). - Folded into unreleased entries: LinuxSLL's stop on its ARPHRD path (#2587) and ARPHRD's __proto_dest__ (#2598), SSLv2 records chained in a segment (#2585), the checksum's move to pcapkit.corekit.checksum.internet (#2586), and IGMPv2's and IGMPv3's versioned name (#2590). - Breaking: InARP moves to pcapkit.protocols.link.inarp with no re-export, joining the DRARP entry (#2596). - Changed: the conventions' new rulings (#2599), the milestone workflow's next-open-milestone lookup (#2591), the PyPy protocols shards (#2604). Fixed: a handled next-layer refusal is quiet under beholder (#2597); the IPX crawlers restore sys.path (#2601). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
LinuxSLL._import_next_layernow checks_sigtermbefore its ARPHRD registry lookup, the orderProtocol._import_next_layerand FRAD's SNAP path use. A parse told to stop at LinuxSLL ('LinuxSLL', the version's own name, either class, orlayer='Link') now keeps a FRAD, GRE, Radiotap or Netlink payload asRaw(LINUX_SLL1:Raw) instead of dispatching it. The EtherType path already honoured every stop.One behaviour change beyond the issue: on the registry path,
layer='Link'used to stop at the next Link layer (LINUX_SLL1:FRAD:Raw); it now stops at LinuxSLL itself, as Ethernet stops before a VLAN tag. A stoppedRawkeepsprotocol_typeas its alias, matching a registry entry registered asRaw. LinuxSLL never shipped, so there is noversionchanged.Closes #2532