Repository navigation
docs: state behaviour in the remaining changelog and scapy provenance notes (#1103) - #2252
Merged
Merged
Conversation
… notes (#1103) Cut the #638 entry, which only corrected the changelog, folding its one new fact (the LICENSE title line and notice comma follow choosealicense.com's template) into the #630 entry. Reword the #876 and #620 entries to state the behaviour, keeping their references. Restate the ScapyFrameGuardTests provenance note as what the guards protect against (#1708). Regenerate CHANGELOG.md.
Owner
Author
|
Review: GOOD TO GO at
|
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, per the owner's rulings on it.
1.5.0.rst:LICENSEheader follows choosealicense.com's template.ResourceWarningthat reddened …") state behaviour.CHANGELOG.mdis regenerated, andchangelog_md.py --checkreports it in step.test_scapy_unit(ScapyFrameGuardTests): the provenance note now reads "Guards against an adapter ending an extraction on such a frame … (refactor(toolkit): revert the cross-engine agreement tests and the adapter code that only mirrors the default engine #1708)". The account of the reverted fix is gone. AST guard OK.test_changelog_md,test_docs_*andtest_conventions_doc_claimsgive 172 passed.test_scapy_unitand the docstring contract give 27 passed.