Repository navigation
fix(engines): require scapy>=2.6.0 in the Scapy and dev extras (#1572) - #1578
Merged
Merged
Conversation
- The Scapy extra was unpinned, so scapy 2.5.0 satisfied it. On 2.5.0 the engine reads a PCAP-NG nanosecond interface as microseconds (scapy drops if_tsresol after a comment option without a newline), and packet2dict reports DNS records as a dict and IP's options key first. 2.6.0, the next release, fixes all three. Both extras now carry "scapy>=2.6.0; python_version >= '3.7'", the marker as PCAP_CT's, since 2.6.0 needs Python 3.7. The Pipfile's dev-packages entry matches. - docs/source/index.rst's engine-prerequisites note states the floor. - test_tier_guard pins both requirement strings; it fails on main. Toolkit, trace and engine-agreement selections fail on 2.5.0 and pass on 2.6.0; tier-guard and docs-claims tests pass.
JarryShaw
force-pushed
the
fix/1572-scapy-minimum-version
branch
from
October 10, 2026 05:24
dc08514 to
ef436c0
Compare
Owner
Author
|
Verdict: GOOD TO GO at
Non-blocking nits:
|
2 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription of your pull request and other information
Closes #1572.
Scapyanddevnow require"scapy>=2.6.0; python_version >= '3.7'", and thePipfile[dev-packages]entry has the same floor and marker. 2.6.0 is the first release after 2.5.0 and fixes all three failures in the issue. The marker works likePCAP_CT's: 2.6.0 declaresRequires-Python >=3.7.main(cc084357f, fix(engines): take a scapy packet's link type and clock from its interface (#1503, #1517, #1549) #1563 included): toolkit, trace and engine-agreement selections give 4 failed on scapy 2.5.0 and 22 passed on 2.6.0. 2.6.0 installs and imports on 3.10–3.14. Apip install --dry-runof the new requirement, run over an existing 2.5.0 install, upgrades it to 2.8.0.docs/source/index.rststates the floor, and that pcapkit does not check the version at run time.DependencyRequirementTestsmethod pins both requirement strings. Onmainit fails with['scapy'] != ["scapy>=2.6.0; python_version >= '3.7'"]. Itsdevhalf fails by itself too.conda/requirements.txtandexamples/benchmark/requirements-common.txtalready pinscapy==2.8.0. There is noPipfile.lock, and no test reads thePipfile. CI installs through the extras.