Repository navigation
test(generators): HTTP/2 sample frames are all written on stream 0 - #1161
Merged
Merged
Conversation
- _httpv2_build put every frame on stream 0, so DATA, HEADERS, PRIORITY, RST_STREAM, PUSH_PROMISE and CONTINUATION were frames no conforming sender writes and decoded as TCP:Raw since #1153. SETTINGS, PING and GOAWAY stay on stream 0; every other type uses stream 1. - PUSH_PROMISE promises stream 2 rather than 0. - New tests/protocols/test_option_generator_httpv2_stream_unit.py pins the stream per type, the payload-only Length, and TCP:HTTP/2 decoding. Closes #1156
Owner
Author
|
Cross-review verdict on
|
3 of 5 tasks
Contributor
|
Coverage: 88.87% (unit tier, Python 3.14,
Per-file detail: the |
JarryShaw
added a commit
that referenced
this pull request
Oct 7, 2026
- 4 new 1.5.0 entries: HTTP/2 sample stream identifiers (#1161), TCP option re-padding (#1163, breaking), format='pcap' output (#1164), declared lengths on truncated captures (#1166, breaking) - extend the PCAP Header (#1159), HIP (#1160) and from_data round-trip (#1162) entries rather than duplicating them - regenerate CHANGELOG.md with util/changelog_md.py - process.rst: entry-count pin re-measured, 189 -> 193 tests/project: conventions_doc_claims, changelog_md and documentation_claims pass; changelog_md.py --check is in step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
make pylint,make mypy,make isort) — ran pylint/isort on the two files only; no new findings on my lines,maketargets not runmake testpasses, and a test case covers the change — only the modules listed below, not the full suitedocs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible — N/A, added centrally after the waveWhat is the purpose of your pull request?
test— tests onlyDescription of your pull request and other information
Closes #1156.
_httpv2_buildnow puts SETTINGS/PING/GOAWAY on stream 0 and every other frame type on stream 1; PUSH_PROMISE promises stream 2. The Length convention needed no generator change: on2c7a97c84the frames already declare the payload length (frame 35 is000000000000000000, not000009…), since #1138 fixedHTTP.make.Probe (
options-transport.pcap, frames 35–44, one per type): before, 4TCP:HTTP/2and 6TCP:Raw(35–38, 40, 44); after, all 10TCP:HTTP/2. No other generated capture changes. Captures are gitignored and generated, so none is committed.Test: new
tests/protocols/test_option_generator_httpv2_stream_unit.py(unit tier, no capture). Without the fix:14 failed, 4 passed, 27 subtests passed; with it:5 passed, 40 subtests passed. No existing test pinned the Raw decoding. Also passing:test_option_roundtrip_unit,test_option_coverage_runtime,test_fields_copy_dispatch_runtime,test_tcp_http_dispatch_unit,test_option_generator_tcp_base_unit,test_generated_pcap_runtime, andtests/project(389 passed, 1 skipped).