Repository navigation
fix(protocols): a layer rebuilt by from_data from a cut capture verifies before its short read is replayed #2703
Description
Found while reviewing #2699 and confirmed by a Sonnet cross-review. GRE.from_data on a cut header rebuilds the right octets (data == full[:n]), but it reads its checksum INVALID and warns.
This happens on the shared path. Every layer base (link, internet, transport, application, and the PCAP header) calls replay_short_read(super().from_data(...), data). So the cut record is applied only after the full-width, zero-filled rebuild has already been parsed and verified.
Any layer that verifies something during parse is affected. Apply the record before verification, or skip verification when the rebuilt layer carries a replayed __short_read__, so a rebuild from a cut capture is as quiet as the parse it came from.
Activity
JarryShaw commentedon Nov 3, 2026
A worker is on it now. Moved to
wip.JarryShaw commentedon Nov 3, 2026
The fix is ready at
5abf254b5. It changesProtocol.from_data,packand__post_init__, so a Sonnet review is running on the local commit before the PR opens. The PR will open once the Actions queue is below 20.JarryShaw commentedon Nov 3, 2026
The PR is #2712.
fix(link): rebuild a cut FRAD header as captured and quietly, or refu…
docs: describe the short-read replay as it runs since #2703, and reso…
fix(protocols): rebuild a cut header with the next layer it parsed wi…