Skip to content

fix(pcapng): a raw bytes option in options= raises AttributeError on self._byte #2353

Closed

Description

@JarryShaw

Describe the bug

A raw bytes item inside an IDB or DSB's options=[...] list raises AttributeError: 'PCAPNG' object has no attribute '_byte'. _make_pcapng_options reads self._byte during make(), but only _make_block_shb and the systemd journal entry maker set it first; every other block maker (IDB, DSB, EPB, ...) does not.

Evidence

Found while reviewing #2346 (DSB bytes secrets_data), on origin/main as well as the PR head — not caused by that PR.

Expected behavior

make() on any PCAP-NG block with a raw-bytes option should not require self._byte to already be set by an earlier call.

Activity

  1. added this to the PyPCAPKit v1.5 milestone on Oct 27, 2026
  2. added
    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 27, 2026
  3. moved this to Pending in PyPCAPKiton Oct 27, 2026
  4. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 27, 2026
  5. moved this from Pending to WIP in PyPCAPKiton Oct 27, 2026
  6. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions