You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(toolkit): adapter messages put the engine name mid-sentence, unlike __engine_name__ #2304
Describe the bug
The pcapkit.toolkit adapters put the engine name inside the sentence instead of leading with it, which the <prefix>: <lowercase description>: … {value!r} form (#2232, #2257) asks for. They also don't spell it the way the engine's __engine_name__ does:
pypcap / pcap_ct UnsupportedCall: IPv4 reassembly is not supported by the pcap-ct engine: …. The engine's name is PCAP_CT.
pypcapfile._parse_ipv4_address / _parse_mac_address: invalid PyPCAPFile IPv4 address: …. The IPv6 UnsupportedCall and the Frame N: TCP over IPv6 … warning are affected too.
pyshark._parse_flag / _parse_epoch: invalid PyShark boolean field tcp.flags_fin: …, invalid PyShark frame.time_epoch: …, PyShark packet 12 has no frame layer
scapy: dependency package 'Scapy' not found
Expected behavior
For example PyShark: invalid boolean field tcp.flags_fin: 'x' and PCAP_CT: IPv4 reassembly is not supported: …, with the prefix taken from __engine_name__. Pins to update: test_pyshark_unit asserts the PyShark strings exactly, and test_pypcapfile_unit asserts the Frame N: TCP over IPv6 warning.
System information
Linux, CPython 3.14.9, checkout main9d504ead5.
Blocked until the #2307 fix PR merges. That fix edits the toolkit adapters' reassembly code, and this one edits the same file, so it starts from the merged tree.
Activity
JarryShaw commentedon Oct 26, 2026
Blocked until the #2307 fix PR merges. That fix edits the toolkit adapters' reassembly code, and this one edits the same file, so it starts from the merged tree.
JarryShaw commentedon Oct 27, 2026
Unblocking — #2307 merged. Open to pick up now.