Skip to content

fix(toolkit): adapter messages put the engine name mid-sentence, unlike __engine_name__ #2304

Closed

Description

@JarryShaw

Describe the bug
The pcapkit.toolkit adapters put the engine name inside the sentence instead of leading with it, which the <prefix>: <lowercase description>: … {value!r} form (#2232, #2257) asks for. They also don't spell it the way the engine's __engine_name__ does:

  • pypcap / pcap_ct UnsupportedCall: IPv4 reassembly is not supported by the pcap-ct engine: …. The engine's name is PCAP_CT.
  • pypcapfile._parse_ipv4_address / _parse_mac_address: invalid PyPCAPFile IPv4 address: …. The IPv6 UnsupportedCall and the Frame N: TCP over IPv6 … warning are affected too.
  • pyshark._parse_flag / _parse_epoch: invalid PyShark boolean field tcp.flags_fin: …, invalid PyShark frame.time_epoch: …, PyShark packet 12 has no frame layer
  • scapy: dependency package 'Scapy' not found

Expected behavior
For example PyShark: invalid boolean field tcp.flags_fin: 'x' and PCAP_CT: IPv4 reassembly is not supported: …, with the prefix taken from __engine_name__. Pins to update: test_pyshark_unit asserts the PyShark strings exactly, and test_pypcapfile_unit asserts the Frame N: TCP over IPv6 warning.

System information
Linux, CPython 3.14.9, checkout main 9d504ead5.

Activity

  1. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
  2. added
    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
    on Oct 26, 2026
  3. moved this to Pending in PyPCAPKiton Oct 26, 2026
  4. JarryShaw commented on Oct 26, 2026

    @JarryShaw
    OwnerAuthor

    Blocked until the #2307 fix PR merges. That fix edits the toolkit adapters' reassembly code, and this one edits the same file, so it starts from the merged tree.

  5. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 26, 2026
  6. moved this from Pending to Blocked in PyPCAPKiton Oct 26, 2026
  7. added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 27, 2026
  8. JarryShaw commented on Oct 27, 2026

    @JarryShaw
    OwnerAuthor

    Unblocking — #2307 merged. Open to pick up now.

  9. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 27, 2026
  10. moved this from Blocked to WIP in PyPCAPKiton Oct 27, 2026
  11. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions