Skip to content

fix(ipv6_ext): IPv6_Ext's version gate reads 'got version=4', not the house form #2302

New issue
New issue
Closed
#2397
Closed
fix(ipv6_ext): IPv6_Ext's version gate reads 'got version=4', not the house form#2302
#2397
Labels
bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 26, 2026

Describe the bug
IPv6_Ext.__post_init__ rejects a non-IPv6 version with IPv6_Ext: only valid for IPv6, got version=4. It has a prefix, but the tail doesn't follow the <prefix>: <lowercase description>: … {value!r} form that #2232 and #2257 use ("must be X, not Y"). The method's own Note: quotes the message too (ESP: only valid for IPv6, got version=4), so it has to change along with it.

Reproduction (main 9d504ead5)

>>> IPv6_Ext(b'\x06\x00\x00\x00\x00\x00\x00\x00', version=4)
ProtocolError: IPv6_Ext: only valid for IPv6, got version=4

Expected behavior
IPv6_Ext: invalid version: must be 6, not 4, with the Note: quote updated to match. No test pins the text.

System information
Linux, CPython 3.14.9, checkout main 9d504ead5.

Activity

  1. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
  2. JarryShaw
    added
    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
    on Oct 26, 2026
  3. github-project-automation
    added this to PyPCAPKiton Oct 26, 2026
  4. JarryShaw
    moved this to Pending in PyPCAPKiton Oct 26, 2026

  5. JarryShaw commented on Oct 26, 2026

    @JarryShaw
    JarryShaw
    on Oct 26, 2026
    OwnerAuthor

    Blocked until the #2286 fix PR merges. That fix edits IPv6_Ext in ipv6_ext.py, and this one edits the same file, so it starts from the merged tree.

  6. JarryShaw
    added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 26, 2026
  7. JarryShaw
    moved this from Pending to Blocked in PyPCAPKiton Oct 26, 2026
  8. JarryShaw
    added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 27, 2026

  9. JarryShaw commented on Oct 27, 2026

    @JarryShaw
    JarryShaw
    on Oct 27, 2026
    OwnerAuthor

    Unblocking — #2286 merged. Open to pick up now.

  10. JarryShaw
    added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 27, 2026
  11. JarryShaw
    moved this from Blocked to WIP in PyPCAPKiton Oct 27, 2026
  12. JarryShaw
    closed this as completedin #2397on Oct 27, 2026
  13. github-project-automation
    moved this from WIP to Done in PyPCAPKiton Oct 27, 2026
  14. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions