Skip to content

chore: stale setup.py, Makefile and MANIFEST.in leftovers, and two reST READMEs outside docs/ #1773

Closed

Description

@JarryShaw

Describe the bug
Stale build and packaging leftovers:

  • setup.py:170: pcapkit_bdist_wheel.run refactors os.path.join(self.dist_dir, "pcapkit"), but dist_dir holds built wheels, not a package tree. It also runs after the wheel is written, so it can never change the wheel.
  • setup.py:50 and :73: the f2format and poseur failures both log "assignment expression backport". Only walrus (:62) is that; f2format back-ports f-strings and poseur back-ports positional-only parameters.
  • make profile runs $(MAKE) -C test profile and fails with test: No such file or directory, because test/Makefile was deleted in 78e28d811. MANIFEST.in:12 prune test names the same missing directory.
  • examples/benchmark/README.rst and examples/legacy_smoke/README.rst are the only reST files outside docs/, against the Markdown-outside-docs ruling. They ship through MANIFEST.in's global-include *.rst.

Expected behavior
Remove or correct each of these, and keep the sdist contents as they are now.

Additional context
Found by the #1103 repo-slice worker, and each item was verified by a Sonnet review. The README rename needs the MANIFEST.in change in the same PR.

Activity

  1. added
    choreMaintenance work: tooling, repo hygiene, no library behaviour change
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  2. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    OwnerAuthor

    A worker is on this.

  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  4. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 15, 2026
  5. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance work: tooling, repo hygiene, no library behaviour change

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions