Skip to content

fix(protocols): pcapkit.protocols.protocol's __all__ omits Protocol #1770

Closed
#1778
Closed
fix(protocols): pcapkit.protocols.protocol's __all__ omits Protocol#1770
#1778
Labels
fixPull requests that fix a defect (fix: subject prefix)

Description

@JarryShaw
JarryShaw
opened on Oct 15, 2026

Describe the bug

  • protocol.py:83: __all__ = ['ProtocolBase'] leaves out Protocol, so from pcapkit.protocols.protocol import * does not export it. The same line is at protocol.py:53 in 1.4.1.post2. pcapkit/protocols/__init__.py:15 imports Protocol explicitly.

Expected behavior
__all__ should list every public class the module defines.

Additional context
Found by the #1103 sweep. An earlier version of this body also asked for the register error message to name ProtocolBase. That was wrong: #1016 settled that the public registration door names the public class (Protocol) even though the guard checks the Base, and #1028 kept the Raises: prose the same way.

Activity

  1. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026

  2. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    JarryShaw
    on Oct 15, 2026
    OwnerAuthor

    A worker is on this.

  3. JarryShaw
    added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 15, 2026
  4. JarryShaw
    moved this to WIP in PyPCAPKiton Oct 15, 2026
  5. JarryShaw
    added this to PyPCAPKiton Oct 15, 2026
  6. JarryShaw
    changed the title [-]fix(protocols): the registry error names Protocol where it checks ProtocolBase, and protocol.__all__ omits Protocol[/-] [+]fix(protocols): pcapkit.protocols.protocol's __all__ omits Protocol[/+] on Oct 15, 2026

  7. JarryShaw commented on Oct 15, 2026

    @JarryShaw
    JarryShaw
    on Oct 15, 2026
    OwnerAuthor

    Narrowed to the __all__ gap. The message change this issue first asked for contradicts #1016, so the fix in progress drops it, as the cross-review found.

  8. JarryShaw
    added a commit that references this issue on Oct 15, 2026

    fix(protocols): export Protocol from pcapkit.protocols.protocol (#1770)…

    376bca2
  9. JarryShaw
    closed this as completedin #1778on Oct 15, 2026
  10. github-project-automation
    moved this from WIP to Done in PyPCAPKiton Oct 15, 2026
  11. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions