Skip to content

fix(pcapng): the four PCAP-NG parser registrars warn when handed their own entry #1401

Closed

Description

@JarryShaw

Describe the bug
#1400 (#1362) gives every parser-storing registrar an identity guard, so handing back the entry already stored no longer warns about a displacement that did not happen. PCAP-NG's four registrars were left out on purpose, because #1398 owns those files: register_block, register_option, register_record and register_secrets in pcapkit/protocols/misc/pcapng.py.

To Reproduce
Re-register any shipped PCAP-NG entry with its own stored value. It warns, although nothing changed.

Expected behavior
The same incumbent == meth early return that #1400 applies elsewhere: silent on the same entry, a warning on a real displacement.

Blocked until #1398 and #1400 merge.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 8, 2026
  2. JarryShaw commented on Oct 8, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1398 (and #1400) have merged. One worker is taking all the PCAP-NG follow-ups together, #1382–#1384, #1401, #1405 and #1406, because they edit the same pcapng.py files.

  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 8, 2026
  4. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions