You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(pcapng): the four PCAP-NG parser registrars warn when handed their own entry #1401
Describe the bug #1400 (#1362) gives every parser-storing registrar an identity guard, so handing back the entry already stored no longer warns about a displacement that did not happen. PCAP-NG's four registrars were left out on purpose, because #1398 owns those files: register_block, register_option, register_record and register_secrets in pcapkit/protocols/misc/pcapng.py.
To Reproduce
Re-register any shipped PCAP-NG entry with its own stored value. It warns, although nothing changed.
Expected behavior
The same incumbent == meth early return that #1400 applies elsewhere: silent on the same entry, a warning on a real displacement.
Unblocked:#1398 (and #1400) have merged. One worker is taking all the PCAP-NG follow-ups together, #1382–#1384, #1401, #1405 and #1406, because they edit the same pcapng.py files.
Activity
JarryShaw commentedon Oct 8, 2026
Unblocked: #1398 (and #1400) have merged. One worker is taking all the PCAP-NG follow-ups together, #1382–#1384, #1401, #1405 and #1406, because they edit the same
pcapng.pyfiles.fix(pcapng)!: PCAP-NG round-trip follow-ups (#1382, #1383, #1384, #1401…