Repository navigation
fix(hip): a HIP packet with no parameters cannot be rebuilt with from_data #1314
Description
Describe the bug
read sets parameters only when some exist (hip.py:591-595), but _make_data reads data.parameters unconditionally (hip.py:764).
To Reproduce
HIP(io.BytesIO(b), len(b), extension=True) then HIP.from_data(p.info) with b = 3b040121 + 36 x 00 (Header Length 4, no parameters): AttributeError: 'HIP' object has no attribute 'parameters'.
Expected behavior
A parameterless packet round-trips (empty parameters).
Found by the internet-v4 round-trip audit (#1202); reproduced on main at 11ae68ebf (repro check D3).
Found by the internet-v4 round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at 11ae68ebf.
Activity