Skip to content

fix(tcp): unknown MPTCP subtypes (incl. MP_TCPRST) read one octet past the option #1214

Closed

Description

@JarryShaw

Describe the bug
At schema/transport/tcp.py:826 the unknown-subtype data field is sized length - 2, but the subtype octet has already been consumed, so the field overruns by one octet. This hits MP_TCPRST (subtype 8, which has no registered handler), 0xf and every unassigned subtype.

To Reproduce
1e048001 rebuilds as 1e05800100000100, with the option length growing from 4 to 5.

Expected behavior
The data field is sized length - 3 and the option rebuilds byte-exactly.

Found by the transport round-trip audit (#1202). I re-ran the repro on main at 630f0a581.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  2. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    OwnerAuthor

    A worker is on it now.

  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  4. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions