Skip to content

fix(pcap): a lone lilendian/bigendian flag is ignored by Header._make_magic #1144

Closed

Description

@JarryShaw

Describe the bug
pcapkit/protocols/misc/pcap/header.py _make_magic honours lilendian/bigendian only when both are given. Passing just one, for example Header(bigendian=True), ignores it and uses the host byte order.

Expected behavior
A single endian flag selects that byte order, or is rejected if the API means it to be paired. Check the docstring and decide which.

Blocked until
#1143 merges, because it edits header.py.

Additional context
Found by the #1125 worker. Not verified yet.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 6, 2026
  2. JarryShaw commented on Oct 6, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1143 merged at 22:35Z, so header.py is free. A worker is on it now.

  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 6, 2026
  4. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions