Repository navigation
Removed the Integer warnings. - #1399
Open
romankassebaum wants to merge 2 commits into
Open
romankassebaum wants to merge 2 commits into
romankassebaum wants to merge 2 commits into
Conversation
Contributor
|
@romankassebaum : Thanks for the pull request. We are currently in a hardening phase for the next release 8.5 in which we test the latest Virtual TreeView source code in our products and our automated test pipeline. We will merge your PR into master after the release. |
zencode1
reviewed
Sep 21, 2026
|
|
||
| end. | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
These extra newlines should be removed before merging.
|
|
||
| function ToInt64(const AValue: Int32): Int64; overload; inline; | ||
| function ToInt64(const AValue: UInt32): Int64; overload; inline; | ||
| function ToInt64(const AValue: Int64): Int64; overload; inline; |
Contributor
There was a problem hiding this comment.
@romankassebaum I wonder why you introduced these helper methods to Virtual TreeView. It seems wrong to have them in every library. There should be a more "central" way to do this. Why didn't you use simple type conversions?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to remove the 64 bit warnings. Therefore I enabled them under project/options.